#18 "Cone of vision" broken on some panorama with firefox

Fermé
Créé il y a 8 ans par zorun · 3 commentaires
zorun a commenté il y a 8 ans

With firefox, the cone of vision is not displayed for some panoramas. For instance, in Rézine's instance, Rabot and Gambetta are broken. The console says this:

jQuery.Deferred exception: canvas is undefined getCapMinMaxVisible@https://pano.rezine.org/static/panorama/js/pano.js:1192:9
update_map@https://pano.rezine.org/static/panorama/js/pano.js:1288:15
load_map@https://pano.rezine.org/static/panorama/js/pano.js:1273:5
g/</j@https://pano.rezine.org/static/panorama/js/jquery-3.0.0.min.js:2:29586
g/</k<@https://pano.rezine.org/static/panorama/js/jquery-3.0.0.min.js:2:29902
 undefined

It works fine with chromium

With firefox, the cone of vision is not displayed for some panoramas. For instance, in Rézine's instance, Rabot and Gambetta are broken. The console says this: ``` jQuery.Deferred exception: canvas is undefined getCapMinMaxVisible@https://pano.rezine.org/static/panorama/js/pano.js:1192:9 update_map@https://pano.rezine.org/static/panorama/js/pano.js:1288:15 load_map@https://pano.rezine.org/static/panorama/js/pano.js:1273:5 g/</j@https://pano.rezine.org/static/panorama/js/jquery-3.0.0.min.js:2:29586 g/</k<@https://pano.rezine.org/static/panorama/js/jquery-3.0.0.min.js:2:29902 undefined ``` It works fine with chromium
Samuel a commenté il y a 8 ans
Collaborateur

I can't reproduce it. I have Firefox 49. Btw it's weird: "canvas is undefined", but "canvas" is set with the

<script>window.onload = load_pano</script>

, line 39 in view.html and the minimap is only draw after:

  $( document ).ready(load_map);

, line 105 in view.html.

Maybe is a question of speed... The function load_pano is not finish before load_map is run.

We may stop all scripts before the end of 'load_pano'. How to do it?

EDIT: Ok. I can reproduce it. It's random with "ctrl+F5". So I would say it's a matter of speed between the 2 functions.

I can't reproduce it. I have Firefox 49. Btw it's weird: "canvas is undefined", but "canvas" is set with the <script>window.onload = load_pano</script> , line 39 in view.html and the minimap is only draw after: $( document ).ready(load_map); , line 105 in view.html. Maybe is a question of speed... The function load_pano is not finish before load_map is run. We may stop all scripts before the end of 'load_pano'. How to do it? EDIT: Ok. I can reproduce it. It's random with "ctrl+F5". So I would say it's a matter of speed between the 2 functions.
Samuel a commenté il y a 8 ans
Collaborateur

Should be fix. Need more test, but theoritically fix.

Should be fix. Need more test, but *theoritically* fix.
zorun a commenté il y a 8 ans
Propriétaire

Indeed, it now works better, thanks!

Indeed, it now works better, thanks!
Connectez-vous pour rejoindre cette conversation.
Pas d'étiquette
bug
ui
Aucun jalon
Pas d'assignataire
2 Participants
Chargement…
Annuler
Enregistrer
Il n'existe pas encore de contenu.