#43 Hardware loaning app

Goal is to handle the loaned hardware to members.

Global philosophy is self-service by members themselves for most operations (ex: register a loan / return).

blocked by #52

Thanks, it looks like a useful application. However, it introduces some modifications that force Coin to use this application:

• INSTALLED_APPS in settings.py (#52)
• changes in urls.py
• changes in coin templates
• changes in coin CSS

It's a more general issue than just this application: the VPN module is activated by default and too tightly integrated in coin, and the new DSL module for Illyse is still not merged in master because of this issue.

Could you at least fix the CSS? There's a commit that has nothing to do here and is probably the source of merge conflict (large change of indentation).

Also, it could be nice to move application-specific CSS to a dedicated CSS file in the application. From the look of it, there seems to be at least the table .actions and table tr.placeholder stuff in this case. This can be done by adding an empty CSS block in the base template (like it is done for javascript), and override it in the application templates.

Ticket for the extensibility issue: #53

In the meantime, can you use a branch other than master for faimaison?

@zorun ok for all of your review suggestions :-). We'll use a faimaison branch meanwhile.

The most important thing that I wanted to be checked is that there is no major model issue.

Could you at least fix the CSS? There's a commit that has nothing to do here and is probably the source of merge conflict (large change of indentation).

Done (pushed @opi indentation changes to master : 846e0c673d)

Side-note: gogs is behaving a way I don't understand about merge conflicts : it says there are merge conflicts when I am able to rebase locally without any conflict to handle.

Also, it could be nice to move application-specific CSS to a dedicated CSS file in the application. From the look of it, there seems to be at least the table .actions and table tr.placeholder stuff in this case. This can be done by adding an empty CSS block in the base template (like it is done for javascript), and override it in the application templates.

Done :)

I can't agree more with the ability to add extra css & js introduced by 3651aabd00.. 513fd4214d ; Thanks for that.

But for me CSS rules like table .actions and table .placeholder can be generic rules in order to have a consistent style for every tables/actions/buttons across the website.

It's not a pledge to revert 0e2ba654b6 now, but I plan to work on template & style consistency some day and maybe will revert it. This is off topic for this pull request (which I'd like to be merged soon).

But for me CSS rules like table .actions and table .placeholder can be generic rules in order to have a consistent style for every tables/actions/buttons across the website.

Good point, currently, it's the only app using such tables, but we have to be extra-careful so that at minimum we make sure to move that CSS as long as there is another app using it.

blocked by #57

#57 has been merged, but there seems to be some conflict now. Ping @jocelyn ?

I think it's ready for merge, just waiting someone else's go to validate that.

@zorun ok, what I did:

• rebased on master (fixing numerous conflicts)
• found a way to display conditionally the link in the in menu_list.html
• re-tested the app

I think it's ready for merge, just waiting someone else's go to validate that.

Some points that may be improved (in the future) :

• the .button.small link to borrow an item is strangely padded, but that seems to be due to some deep foundation css I don't want to fight with for now
• We could discuss about another approach to conditionally display menu items… But I think this one is acceptable for now.

I think it's ready for merge, just waiting someone else's go to validate that.

Ok, timeout I self-validated it :-)

I deploy it right now on faimaison instance.