I have adapted your branch to the VPN app change, and added a few fixes. I have also disabled the DSL app by default, just like the VPN (I don't know if you use it for faimaison).
It's in the editable-installed-apps branch, can you have a quick look before I merge it?
Well, in fact, this is independent from #57.
I have adapted your branch to the VPN app change, and added a few fixes. I have also disabled the DSL app by default, just like the VPN (I don't know if you use it for faimaison).
It's in the `editable-installed-apps` branch, can you have a quick look before I merge it?
@zorun Reviewed and tested, seems fine, good job :-)
(btw, that implicit organization with optional apps in the root dir seems a bit messy to me, but that's a long-term question, clearly outside the scope of this PR).
@zorun Reviewed and tested, seems fine, good job :-)
(btw, that implicit organization with optional apps in the root dir seems a bit messy to me, but that's a long-term question, clearly outside the scope of this PR).
Yes, optional apps should probably have their own git repositories (and could be available through pip).
Great, merged in 24cffdbae6a1cb7b100d3d8cf05bbbf938081441. Thanks for the work!
Yes, optional apps should probably have their own git repositories (and could be available through pip).
zorun
fix #52 relates #53
@zorun bump ?
Yes sorry, I plan to test that after #57 (and merge both together).
Well, in fact, this is independent from #57.
I have adapted your branch to the VPN app change, and added a few fixes. I have also disabled the DSL app by default, just like the VPN (I don't know if you use it for faimaison).
It's in the
editable-installed-appsbranch, can you have a quick look before I merge it?@zorun Reviewed and tested, seems fine, good job :-)
(btw, that implicit organization with optional apps in the root dir seems a bit messy to me, but that's a long-term question, clearly outside the scope of this PR).
Great, merged in
24cffdbae6. Thanks for the work!Yes, optional apps should probably have their own git repositories (and could be available through pip).