The most important is the creation of several conf var. Thanks to these, everyone in french country could create his own wireless isp. In parallel, I created a YunoHost package on this repo.
https://code.ffdn.org/ljf/wifiwithme_ynh
The 2 other commit fix a missing dependencies and optimize the logging conf to be able to be compatible with gunicorn.
Hi,
Here is my contribution to wifi-with-me :) .
The most important is the creation of several conf var. Thanks to these, everyone in french country could create his own wireless isp. In parallel, I created a YunoHost package on this repo.
https://code.ffdn.org/ljf/wifiwithme_ynh
The 2 other commit fix a missing dependencies and optimize the logging conf to be able to be compatible with gunicorn.
See u,
ljf
#19 #28
Thanks a lot ! That's good ; some things to fix/clarify before the merge IMHO:
ced61b7d3c : I do not understand the intent of the commit
d2109f2fa7 : could you create a dedicated template tag (something called like obfuscate_email) instead of that too generic replace ?
PS: Well spotted for the legal page and the connect_local / connect_internet stuff :-) (that new Django version is not yet in use at FAImaison…)
Thanks a lot ! That's good ; some things to fix/clarify before the merge IMHO:
- ced61b7d3c : I do not understand the intent of the commit
- d2109f2fa7 : could you create a dedicated template tag (something called like `obfuscate_email`) instead of that too generic `replace` ?
PS: Well spotted for the legal page and the connect_local / connect_internet stuff :-) (that new Django version is not yet in use at FAImaison…)
I don't know why sqlparse is in dependencie, but on a clear setup the python manage.py command ask me to install sqlparse. You are using an sqlite db may be it's an explanation ?
ced61b7d3c : without this bugfix, latitude and longitude are written in a french format number but coma are not javascript compatible so the latitude and longitude was truncated.
d2109f2fa7 : if I found the time yes, I am agree with this idea.
Thanks for reviewing !
I don't know why sqlparse is in dependencie, but on a clear setup the python manage.py command ask me to install sqlparse. You are using an sqlite db may be it's an explanation ?
* ced61b7d3c : without this bugfix, latitude and longitude are written in a french format number but coma are not javascript compatible so the latitude and longitude was truncated.
* d2109f2fa7 : if I found the time yes, I am agree with this idea.
Hi, Here is my contribution to wifi-with-me :) .
The most important is the creation of several conf var. Thanks to these, everyone in french country could create his own wireless isp. In parallel, I created a YunoHost package on this repo. https://code.ffdn.org/ljf/wifiwithme_ynh
The 2 other commit fix a missing dependencies and optimize the logging conf to be able to be compatible with gunicorn.
See u, ljf
#19 #28
Thanks :-)
Currently reviewing…
Out of curiosity : why is sqlparse required ?
Thanks a lot ! That's good ; some things to fix/clarify before the merge IMHO:
ced61b7d3c
: I do not understand the intent of the commitd2109f2fa7
: could you create a dedicated template tag (something called likeobfuscate_email
) instead of that too genericreplace
?PS: Well spotted for the legal page and the connect_local / connect_internet stuff :-) (that new Django version is not yet in use at FAImaison…)
Thanks for reviewing !
I don't know why sqlparse is in dependencie, but on a clear setup the python manage.py command ask me to install sqlparse. You are using an sqlite db may be it's an explanation ?
ced61b7d3c
: without this bugfix, latitude and longitude are written in a french format number but coma are not javascript compatible so the latitude and longitude was truncated.d2109f2fa7
: if I found the time yes, I am agree with this idea.Got it for sqlparse.
Waiting for you fix on
d2109f2fa7
if it's ok for you :-).Done
@ljf Awesome! Thanks for your attention to details and shaping things properly.
merge
d2109f2fa7
andd2109f2fa7
and we're good for merge.I have merged the 2 commit about email obfuscation