#62 Add moar contribution types

Ouvert
alexAubin veut fusionner 1 commits à partir de alexAubin/moar-contrib-types vers FFDN/master

This is open to discussion : here's a proposal to add two new contribution types

  • One to declare willing to join the network by sharing or (inclusive) receiving internet. This is in contrast to the two existing options which force you to force choosing one or the other. (Dunno how much sense that makes, but currently bootstraping our network in Strasbourg, people want to help and don't have one option in mind)

  • The other is to declare a "point of interest" which would provide a strategic interest in the development of the network. So even if we don't have a person yet, we often talk about this place for short/mid-term plans.

Here's a screenshot summarizing the map view (though other views are impacted)

This is open to discussion : here's a proposal to add two new contribution types - One to declare willing to join the network by sharing or (inclusive) receiving internet. This is in contrast to the two existing options which force you to force choosing one or the other. (Dunno how much sense that makes, but currently bootstraping our network in Strasbourg, people want to help and don't have one option in mind) - The other is to declare a "point of interest" which would provide a strategic interest in the development of the network. So even if we don't have a person yet, we often talk about this place for short/mid-term plans. Here's a screenshot summarizing the map view (though other views are impacted)
alexAubin a commenté il y a 6 ans
Publier

Any thoughts on this ? :S

Any thoughts on this ? :S
jocelyn a commenté il y a 6 ans
Propriétaire

Sorry, I'm a bit late on my reviewing/maintaining stuff :x. Thanks for bumping.

Seems really useful, I like it !

On the code side :

Little to say, except :

  • I think there are missing db migration(s)

On wording :

  • I'd suggest a rewording for clarity (given that this is people that push their own location) :

    • « point stratégique à prospecter » -> « hébergement possible d'un relais (ex: point haut) »
    • « Ajouter un point qui serait stratégique (e.g. point en hauteur)) » -> « Proposer l'hébergement d'un relais (ex: point haut) »

WDYT ?

PS: to deserve my nitpicker reputation : « e.g. » is English, « ex : » is French.

I'll look at #63 later.

Sorry, I'm a bit late on my reviewing/maintaining stuff :x. Thanks for bumping. Seems really useful, I like it ! On the code side : Little to say, except : - I think there are missing db migration(s) On wording : - I'd suggest a rewording for clarity (given that this is people that push their own location) : - « point stratégique à prospecter » -> « hébergement possible d'un relais (ex: point haut) » - « Ajouter un point qui serait stratégique (e.g. point en hauteur)) » -> « Proposer l'hébergement d'un relais (ex: point haut) » WDYT ? PS: to deserve my nitpicker reputation : « e.g. » is English, « ex : » is French. I'll look at #63 later.
alexAubin a commenté il y a 6 ans
Publier

It's okay / understood, we are all working on so many (too many ?) things :P

I think there are missing db migration(s)

Indeed, I shall add them

a rewording for clarity (given that this is people that push their own location)

Hmyea but what I had in mind about the yellow things was precisely that it was also meant for some kind of "wishlist" :s

PS: to deserve my nitpicker reputation : « e.g. » is English, « ex : » is French.

Indeed ;P

Thanks for the feedback !

It's okay / understood, we are all working on so many (too many ?) things :P >I think there are missing db migration(s) Indeed, I shall add them > a rewording for clarity (given that this is people that push their own location) Hmyea but what I had in mind about the yellow things was precisely that it was also meant for some kind of "wishlist" :s >PS: to deserve my nitpicker reputation : « e.g. » is English, « ex : » is French. Indeed ;P Thanks for the feedback !
jocelyn a commenté il y a 6 ans
Propriétaire

a rewording for clarity (given that this is people that push their own location)

Hmyea but what I had in mind about the yellow things was precisely that it was also meant for some kind of "wishlist" :s

IMHO, that does not really fits the current goal of wifi-with-me form : being straigthforward for newcommers. You have to be already working into radio planning to add such a « wished relay » point. For newcomers, this migtht not be understood and confusing.

On the other hand the « I could offer a relay » choice may be better understood (and fits some « public » use cases, at least at FAImaison).

Thinking: maybe those two options are two different things, and, that « wishlist choice » could be allowed in admin, but not offered as a choice in the public form ?

>> a rewording for clarity (given that this is people that push their own location) > > Hmyea but what I had in mind about the yellow things was precisely that it was also meant for some kind of "wishlist" :s IMHO, that does not really fits the current goal of wifi-with-me form : being straigthforward for newcommers. You have to be already working into radio planning to add such a « wished relay » point. For newcomers, this migtht not be understood and confusing. On the other hand the « I could offer a relay » choice may be better understood (and fits some « public » use cases, at least at FAImaison). Thinking: maybe those two options are two different things, and, that « wishlist choice » could be allowed in admin, but not offered as a choice in the public form ?
alexAubin a commenté il y a 6 ans
Publier

Thinking: maybe those two options are two different things, and, that « wishlist choice » could be allowed in admin, but not offered as a choice in the public form ?

Yes, I was also starting to think this ! (I understand and agree that it's not the spirit of wifi-with-me to show this as a public choice :P )

>Thinking: maybe those two options are two different things, and, that « wishlist choice » could be allowed in admin, but not offered as a choice in the public form ? Yes, I was also starting to think this ! (I understand and agree that it's not the spirit of wifi-with-me to show this as a public choice :P )
jocelyn a commenté il y a 6 ans
Propriétaire

As we agree, just let me know when you upgrade PR :-)

As we agree, just let me know when you upgrade PR :-)
Cette pull request peut être fusionnée automatiquement.
Connectez-vous pour rejoindre cette conversation.
Aucun jalon
Pas d'assignataire
2 Participants
Chargement…
Annuler
Enregistrer
Il n'existe pas encore de contenu.