Adds an 'HANDLE_BALANCE' parameter in settings

This commit adds an 'HANDLE_BALANCE' parameter in 'settings_base.py'.
When False (default), it deactivates balance calculations and the balance display in the user and the admin interface.

README.md

@@ -342,6 +342,7 @@ List of available settings in your `settings_local.py` file.
 - `SUBSCRIPTION_REFERENCE`: Pattern used to display a unique reference for any subscription. Helpful for bank wire transfer identification
 - `PAYMENT_DELAY`: Payment delay in days for issued invoices ( default is 30 days which is the default in french law)
 - `MEMBER_CAN_EDIT_PROFILE`: Allow members to edit their profiles
+- `HANDLE_BALANCE`: Allows to handle money balances for members (False default)
 
 Accounting logs
 ---------------

coin/billing/models.py

@@ -488,6 +488,8 @@ def update_accounting_for_member(member):
     Met à jour le status des factures, des paiements et le solde du compte
     d'un utilisateur
     """
+    if not settings.HANDLE_BALANCE:
+        return
 
     accounting_log.info("Updating accounting for member {} ...".format(member))
     accounting_log.info(

coin/billing/tests.py

@@ -5,7 +5,7 @@ import datetime
 from decimal import Decimal
 
 from django.conf import settings
-from django.test import TestCase, Client
+from django.test import TestCase, Client, override_settings
 from freezegun import freeze_time
 from coin.members.tests import MemberTestsUtils
 from coin.members.models import Member, LdapUser
@@ -15,6 +15,7 @@ from coin.billing.create_subscriptions_invoices import create_member_invoice_for
 from coin.billing.create_subscriptions_invoices import create_all_members_invoices_for_a_period
 
 
+@override_settings(HANDLE_BALANCE=True)
 class BillingInvoiceCreationTests(TestCase):
 
     def setUp(self):

coin/members/admin.py

@@ -9,6 +9,7 @@ from django.contrib.auth.models import Group, Permission
 from django.contrib.contenttypes.models import ContentType
 from django.http import HttpResponseRedirect
 from django.conf.urls import url
+from django.conf import settings
 from django.db.models.query import QuerySet
 from django.core.urlresolvers import reverse
 from django.utils.html import format_html
@@ -109,14 +110,13 @@ class MemberAdmin(UserAdmin):
 
         # if obj is null then it is a creation, otherwise it is a modification
         if obj:
-            return (
+            fieldsets = (
                 ('Adhérent', {'fields': (
                     ('status', 'date_joined', 'resign_date'),
                     'type',
                     ('first_name', 'last_name', 'nickname'),
                     'organization_name',
-                    'comments',
-                    'balance' # XXX we shouldn't need this, the default value should be used
+                    'comments'
                 )}),
                 coord_fieldset,
                 auth_fieldset,
@@ -124,18 +124,20 @@ class MemberAdmin(UserAdmin):
                 (None, {'fields': ('date_last_call_for_membership_fees_email',)})
             )
         else:
-            return (
+            fieldsets = (
                 ('Adhérent', {'fields': (
                     ('status', 'date_joined'),
                     'type',
                     ('first_name', 'last_name', 'nickname'),
                     'organization_name',
-                    'comments',
-                    'balance')}),
+                    'comments')}),
                 coord_fieldset,
                 auth_fieldset,
                 perm_fieldset
             )
+        if settings.HANDLE_BALANCE:
+            fieldsets[0][1]['fields'] += ('balance',)
+        return fieldsets
 
     radio_fields = {"type": admin.HORIZONTAL}
 

coin/members/templates/members/invoices.html

@@ -2,7 +2,9 @@
 
 {% block content %}
 
-<h2>Balance : {{ balance|floatformat }} €</h2>
+{% if handle_balance %}
+	<h2>Balance : {{ balance|floatformat }} €</h2>
+{% endif %}
 
 <h2>Mes factures</h2>
 

coin/members/views.py

@@ -61,6 +61,7 @@ def invoices(request):
 
     return render_to_response('members/invoices.html',
                               {'balance' : balance, 
+                               'handle_balance' : settings.HANDLE_BALANCE, 
                                'invoices': invoices, 
                                'payments': payments},
                               context_instance=RequestContext(request))

coin/settings_base.py

@@ -272,3 +272,6 @@ FEEDS = (
 
 # Member can edit their own data
 MEMBER_CAN_EDIT_PROFILE = False
+
+# Allows to deactivate displays and calculations of balances.
+HANDLE_BALANCE = False