#12 The resources units should be modifiable as a (local_)settings

Ouvert
milouse veut fusionner 2 commits à partir de milouse/ed-fix-11 vers jocelyn/master

Fix #11

Fix #11
jocelyn a commenté il y a 6 ans
Propriétaire

Excellent. Two details :

I'm really happy to see you around :-)

Excellent. Two details : - formatting of the setting parenthesis is not very git-friendly https://code.ffdn.org/jocelyn/transparency/pulls/12/files#diff-0951e555c3efaad48ecd5e80df8144312bf364bR128 (yeah, nitpicking) - could you document that setting in README.md I'm really happy to see you around :-)
Étienne Deparis a commenté il y a 6 ans
Publier

Ok, no problem.

I've a related newbie question: do we have to keep a tuple of tuples for the choices parameter or can it be an array of tuples? What is the difference, with the line 232 for example?

  • could you document that setting in README.md

Yes. But as it isn't a required modification, I purpose to add a « Additionnal settings » section to the readme? In which we can move the Organization Name too, to keep only the required parameters for a working env (SECRET_KEY and DEBUG). What do you think?

> - formatting of the setting parenthesis is not very git-friendly https://code.ffdn.org/jocelyn/transparency/pulls/12/files#diff-0951e555c3efaad48ecd5e80df8144312bf364bR128 (yeah, nitpicking) Ok, no problem. I've a related newbie question: do we have to keep a tuple of tuples for the `choices` parameter or can it be an array of tuples? What is the difference, with the [line 232](https://code.ffdn.org/jocelyn/transparency/src/master/costs/models.py#L232) for example? > - could you document that setting in README.md Yes. But as it isn't a required modification, I purpose to add a « Additionnal settings » section to the readme? In which we can move the Organization Name too, to keep only the required parameters for a working env (SECRET_KEY and DEBUG). What do you think?
jocelyn a commenté il y a 6 ans
Propriétaire

I've a related newbie question: do we have to keep a tuple of tuples for the choices parameter or can it be an array of tuples? What is the difference, with the line 232 for example?

Does not realy matter, both works. IIRC there is an irrelevant pico-slight performance hit in using lists rather than tuples. IMHO, that is readability that matters most.

   could you document that setting in README.md

Yes. But as it isn't a required modification, I purpose to add a « Additionnal settings » section to the readme? In which we can move the Organization Name too, to keep only the required parameters for a working env (SECRET_KEY and DEBUG). What do you think?

:+1:

> I've a related newbie question: do we have to keep a tuple of tuples for the choices parameter or can it be an array of tuples? What is the difference, with the line 232 for example? Does not realy matter, both works. IIRC there is an irrelevant pico-slight performance hit in using lists rather than tuples. IMHO, that is readability that matters most. >> could you document that setting in README.md >Yes. But as it isn't a required modification, I purpose to add a « Additionnal settings » section to the readme? In which we can move the Organization Name too, to keep only the required parameters for a working env (SECRET_KEY and DEBUG). What do you think? :+1:
jocelyn a commenté il y a 6 ans
Propriétaire

Let me know if you upgrade a PR. Gogs is stupid enough not to notice and notify.

Let me know if you upgrade a PR. Gogs is stupid enough not to notice and notify.
Étienne Deparis a commenté il y a 6 ans
Publier

PR updated and rebased against master

I've modified heavily the README file, you can see the resulting output there if you want. Hope you'll like it :)

PR updated and rebased against master I've modified heavily the README file, you can [see the resulting output there](https://code.ffdn.org/milouse/transparency/src/ed-fix-11) if you want. Hope you'll like it :)
Cette pull request peut être fusionnée automatiquement.
Connectez-vous pour rejoindre cette conversation.
Pas d'étiquette
Aucun jalon
Pas d'assignataire
2 Participants
Chargement…
Annuler
Enregistrer
Il n'existe pas encore de contenu.