#10 Improve the current README file

Merged
jocelyn merged 5 commits from milouse/ed-fix-readme into jocelyn/master 6 years ago

To ease project onboarding

To ease project onboarding
jocelyn commented 6 years ago
Owner

Nice surprise, thanks @milouse :-)

A single remark :

  • missing venv activation before runserver
Nice surprise, thanks @milouse :-) A single remark : - missing venv activation before runserver
Étienne Deparis commented 6 years ago
Poster

I'll try to use it for Duchesse :) (I just discovered it is open sourced, I thought it was a hidden project only)

I don't add venv activation before runserver, as I think the various commands from the README will be entered in from the top to the bottom of the file the first time. The following times, people will remember they have to use the venv they created the first time.

I don't know if activating a venv on top an already activated venv can cause trouble or not? If not, it may be inserted again.

I'll try to use it for Duchesse :) (I just discovered it is open sourced, I thought it was a hidden project only) I don't add venv activation before runserver, as I think the various commands from the README will be entered in from the top to the bottom of the file the first time. The following times, people will remember they have to use the venv they created the first time. I don't know if activating a venv on top an already activated venv can cause trouble or not? If not, it may be inserted again.
jocelyn commented 6 years ago
Owner

I'll try to use it for Duchesse :) (I just discovered it is open sourced, I thought it was a hidden project only)

Cool :-)

I don't know if activating a venv on top an already activated venv can cause trouble or not? If not, it may be inserted again.

No it does not cause trouble.

> I'll try to use it for Duchesse :) (I just discovered it is open sourced, I thought it was a hidden project only) Cool :-) > I don't know if activating a venv on top an already activated venv can cause trouble or not? If not, it may be inserted again. No it does not cause trouble.
Étienne Deparis commented 6 years ago
Poster

Updated ;)

Updated ;)
jocelyn commented 6 years ago
Owner

Allez zou, merci beaucoup :-)

(j'ai failli grogner sur le commentaire # inline sur la ligne du activate qui peut être porteur de confusion mais j'ai pris sur moi ;-).

Allez zou, merci beaucoup :-) (j'ai failli grogner sur le commentaire `#` inline sur la ligne du activate qui peut être porteur de confusion mais j'ai pris sur moi ;-).
This pull request has been merged successfully!
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.