Add various TODO items

coin/members/models.py

@@ -52,6 +52,8 @@ class Member(CoinLdapSyncModel):
                                          verbose_name=u'Téléphone fixe')
     mobile_phone_number = models.CharField(max_length=25, blank=True,
                                            verbose_name=u'Téléphone mobile')
+    # TODO: use a django module that provides an address model? (would
+    # support more countries and address types)
     address = models.TextField(verbose_name=u'Adresse')
     postal_code = models.CharField(max_length=15,
                                    verbose_name=u'Code postal')
@@ -64,6 +66,8 @@ class Member(CoinLdapSyncModel):
                                   blank=False,
                                   default=datetime.date.today,
                                   verbose_name='Date de première adhésion')
+    # TODO: for data retention, prevent deletion of a user object while
+    # the resign date is recent enough (e.g. one year in France).
     resign_date = models.DateField(null=True, blank=True,
                                    verbose_name='Date de départ de '
                                    'l\'association')

coin/offers/models.py

@@ -41,6 +41,8 @@ class OfferSubscription(models.Model):
         blank=False,
         default=datetime.date.today,
         verbose_name='Date de souscription à l\'offre')
+    # TODO: for data retention, prevent deletion of a subscription object
+    # while the resign date is recent enough (e.g. one year in France).
     resign_date = models.DateField(
         null=True,
         blank=True,

coin/resources/models.py

@@ -48,6 +48,8 @@ class IPSubnet(models.Model):
     # TODO: find some way to signal to Subscriptions objects when a subnet
     # gets modified (so that the subscription can update the LDAP backend
     # accordingly)
+    # Actually, a better idea would be to build a custom relation and update
+    # LDAP in the relation itself.
     inet = CidrAddressField(blank=True, validators=[validate_subnet],
                             verbose_name="Leave empty for automatic allocation")
     objects = NetManager()

coin/reverse_dns/models.py

@@ -4,11 +4,19 @@ from django.core.exceptions import ValidationError
 from django.core.validators import MinValueValidator
 from netfields import InetAddressField, NetManager
 from netaddr import IPAddress
+import ldapdb.models
+from ldapdb.models.fields import CharField, IntegerField, ListField
+
+from coin.models import CoinLdapSyncModel
 
 # TODO: validate DNS names with this regex
 REGEX = r'(?:[A-Z0-9](?:[A-Z0-9-]{0,61}[A-Z0-9])?\.)+(?:[A-Z]{2,6}|[A-Z0-9-]{2,})\.?$'
 
 class NameServer(models.Model):
+    # TODO: signal to IPSubnet when we are modified, so that is saves the
+    # result into LDAP.  Actually, better: build a custom M2M relation
+    # between NameServer and IPSubnet (see Capslock), and save in LDAP
+    # there.
     dns_name = models.CharField(max_length=255,
                                 help_text="Example: ns1.example.com")
     description = models.CharField(max_length=255, blank=True,