Browse Source

[2252] simplify complicated if-else lines (unrelated to #2252)

Naoki Kambe 12 years ago
parent
commit
01b2a2fa9d
1 changed files with 3 additions and 7 deletions
  1. 3 7
      src/bin/xfrin/xfrin.py.in

+ 3 - 7
src/bin/xfrin/xfrin.py.in

@@ -1032,14 +1032,10 @@ class XfrinConnection(asyncore.dispatcher):
             # (if not yet - possible in case of xfr-level exception) as soon
             # as possible
             self._diff = None
-            if ret == XFRIN_OK:
-                # count successful xfer requests
+            counter_dict = {XFRIN_OK: 'xfrsuccess', XFRIN_FAIL: 'xfrfail'}
+            if ret in counter_dict:
                 self._counters.inc('zones', self._zone_name.to_text(),
-                                   'xfrsuccess')
-            elif ret == XFRIN_FAIL:
-                # count failed xfer requests
-                self._counters.inc('zones', self._zone_name.to_text(),
-                                   'xfrfail')
+                                   counter_dict[ret])
 
         return ret