Browse Source

[4266] Cloned overloaded process packet got exception log message

Francis Dupont 9 years ago
parent
commit
08799aa823

+ 11 - 4
src/bin/dhcp4/dhcp4_messages.mes

@@ -449,10 +449,17 @@ This error message is issued when preparing an on-wire format of the packet
 has failed. The first argument identifies the client and the DHCP transaction.
 has failed. The first argument identifies the client and the DHCP transaction.
 The second argument includes the error string.
 The second argument includes the error string.
 
 
-% DHCP4_PACKET_PROCESS_EXCEPTION exception occurred during packet processing: %1
-This error message indicates that an exception was raised during packet processing
-that was not caught by other, more specific exception handlers. This packet will
-be dropped and the server will continue operation.
+% DHCP4_PACKET_PROCESS_EXCEPTION exception occurred during packet processing
+This error message indicates that a non-standard exception was raised
+during packet processing that was not caught by other, more specific
+exception handlers. This packet will be dropped and the server will
+continue operation.
+
+% DHCP4_PACKET_PROCESS_STD_EXCEPTION exception occurred during packet processing: %1
+This error message indicates that a standard exception was raised
+during packet processing that was not caught by other, more specific
+exception handlers. This packet will be dropped and the server will
+continue operation.
 
 
 % DHCP4_PACKET_RECEIVED %1: %2 (type %3) received from %4 to %5 on interface %6
 % DHCP4_PACKET_RECEIVED %1: %2 (type %3) received from %4 to %5 on interface %6
 A debug message noting that the server has received the specified type of
 A debug message noting that the server has received the specified type of

+ 2 - 3
src/bin/dhcp4/dhcp4_srv.cc

@@ -420,14 +420,13 @@ Dhcpv4Srv::run() {
         } catch (const std::exception& e) {
         } catch (const std::exception& e) {
             // General catch-all exception that are not caught by more specific
             // General catch-all exception that are not caught by more specific
             // catches. This one is for exceptions derived from std::exception.
             // catches. This one is for exceptions derived from std::exception.
-            LOG_ERROR(packet4_logger, DHCP4_PACKET_PROCESS_EXCEPTION)
+            LOG_ERROR(packet4_logger, DHCP4_PACKET_PROCESS_STD_EXCEPTION)
                 .arg(e.what());
                 .arg(e.what());
         } catch (...) {
         } catch (...) {
             // General catch-all exception that are not caught by more specific
             // General catch-all exception that are not caught by more specific
             // catches. This one is for other exceptions, not derived from
             // catches. This one is for other exceptions, not derived from
             // std::exception.
             // std::exception.
-            LOG_ERROR(packet4_logger, DHCP4_PACKET_PROCESS_EXCEPTION)
-                .arg("an unknown exception not derived from std::exception");
+	    LOG_ERROR(packet4_logger, DHCP4_PACKET_PROCESS_EXCEPTION);
         }
         }
     }
     }
 
 

+ 11 - 4
src/bin/dhcp6/dhcp6_messages.mes

@@ -417,16 +417,23 @@ because packets of this type must be sent to multicast. The first argument
 specifies the client and transaction identification information, the
 specifies the client and transaction identification information, the
 second argument specifies packet type.
 second argument specifies packet type.
 
 
-% DHCP6_PACKET_PROCESS_EXCEPTION exception occurred during packet processing: %1
-This error message indicates that an exception was raised during packet processing
-that was not caught by other, more specific exception handlers. This packet will
-be dropped and the server will continue operation.
+% DHCP6_PACKET_PROCESS_EXCEPTION exception occurred during packet processing
+This error message indicates that a non-standard exception was raised
+during packet processing that was not caught by other, more specific
+exception handlers. This packet will be dropped and the server will
+continue operation.
 
 
 % DHCP6_PACKET_PROCESS_FAIL processing of %1 message received from %2 failed: %3
 % DHCP6_PACKET_PROCESS_FAIL processing of %1 message received from %2 failed: %3
 This is a general catch-all message indicating that the processing of the
 This is a general catch-all message indicating that the processing of the
 specified packet type from the indicated address failed.  The reason is given in the
 specified packet type from the indicated address failed.  The reason is given in the
 message.  The server will not send a response but will instead ignore the packet.
 message.  The server will not send a response but will instead ignore the packet.
 
 
+% DHCP6_PACKET_PROCESS_STD_EXCEPTION exception occurred during packet processing: %1
+This error message indicates that a standard exception was raised
+during packet processing that was not caught by other, more specific
+exception handlers. This packet will be dropped and the server will
+continue operation.
+
 % DHCP6_PACKET_RECEIVED %1: %2 (type %3) received from %4 to %5 on interface %6
 % DHCP6_PACKET_RECEIVED %1: %2 (type %3) received from %4 to %5 on interface %6
 A debug message noting that the server has received the specified type of
 A debug message noting that the server has received the specified type of
 packet on the specified interface. The first argument specifies the
 packet on the specified interface. The first argument specifies the

+ 2 - 3
src/bin/dhcp6/dhcp6_srv.cc

@@ -293,13 +293,12 @@ bool Dhcpv6Srv::run() {
         } catch (const std::exception& e) {
         } catch (const std::exception& e) {
             // General catch-all standard exceptions that are not caught by more
             // General catch-all standard exceptions that are not caught by more
             // specific catches.
             // specific catches.
-            LOG_ERROR(packet6_logger, DHCP6_PACKET_PROCESS_EXCEPTION)
+            LOG_ERROR(packet6_logger, DHCP6_PACKET_PROCESS_STD_EXCEPTION)
                 .arg(e.what());
                 .arg(e.what());
         } catch (...) {
         } catch (...) {
             // General catch-all non-standard exception that are not caught
             // General catch-all non-standard exception that are not caught
             // by more specific catches.
             // by more specific catches.
-            LOG_ERROR(packet6_logger, DHCP6_PACKET_PROCESS_EXCEPTION)
-                .arg("an unknown exception not derived from std::exception");
+            LOG_ERROR(packet6_logger, DHCP6_PACKET_PROCESS_EXCEPTION);
         }
         }
     }
     }