Browse Source

[2218] Update other tests for previous commit's API change

Mukund Sivaraman 12 years ago
parent
commit
12d5f67f3e
1 changed files with 20 additions and 28 deletions
  1. 20 28
      src/lib/datasrc/memory/tests/memory_client_unittest.cc

+ 20 - 28
src/lib/datasrc/memory/tests/memory_client_unittest.cc

@@ -180,13 +180,11 @@ TEST_F(MemoryClientTest, load) {
     // should not result in any exceptions.
     client_->load(Name("example.org"),
                   TEST_DATA_DIR "/example.org.zone");
-    isc::datasrc::memory::ZoneTable::FindResult
-        result(client_->findZoneData(Name("example.org")));
-    EXPECT_EQ(result::SUCCESS, result.code);
-    ASSERT_NE(static_cast<ZoneData*>(NULL),
-              result.zone_data);
-    EXPECT_FALSE(result.zone_data->isSigned());
-    EXPECT_FALSE(result.zone_data->isNSEC3Signed());
+    const ZoneData* zone_data =
+        client_->findZoneData(Name("example.org"));
+    ASSERT_NE(static_cast<const ZoneData*>(NULL), zone_data);
+    EXPECT_FALSE(zone_data->isSigned());
+    EXPECT_FALSE(zone_data->isNSEC3Signed());
 }
 
 TEST_F(MemoryClientTest, loadFromIterator) {
@@ -232,13 +230,11 @@ TEST_F(MemoryClientTest, loadMemoryAllocationFailures) {
 TEST_F(MemoryClientTest, loadNSEC3Signed) {
     client_->load(Name("example.org"),
                   TEST_DATA_DIR "/example.org-nsec3-signed.zone");
-    isc::datasrc::memory::ZoneTable::FindResult
-        result(client_->findZoneData(Name("example.org")));
-    EXPECT_EQ(result::SUCCESS, result.code);
-    ASSERT_NE(static_cast<ZoneData*>(NULL),
-              result.zone_data);
-    EXPECT_TRUE(result.zone_data->isSigned());
-    EXPECT_TRUE(result.zone_data->isNSEC3Signed());
+    const ZoneData* zone_data =
+        client_->findZoneData(Name("example.org"));
+    ASSERT_NE(static_cast<const ZoneData*>(NULL), zone_data);
+    EXPECT_TRUE(zone_data->isSigned());
+    EXPECT_TRUE(zone_data->isNSEC3Signed());
 }
 
 TEST_F(MemoryClientTest, loadNSEC3EmptySalt) {
@@ -246,25 +242,21 @@ TEST_F(MemoryClientTest, loadNSEC3EmptySalt) {
     // or anything.
     client_->load(Name("example.org"),
                   TEST_DATA_DIR "/example.org-nsec3-empty-salt.zone");
-    isc::datasrc::memory::ZoneTable::FindResult
-        result(client_->findZoneData(Name("example.org")));
-    EXPECT_EQ(result::SUCCESS, result.code);
-    ASSERT_NE(static_cast<ZoneData*>(NULL),
-              result.zone_data);
-    EXPECT_TRUE(result.zone_data->isSigned());
-    EXPECT_TRUE(result.zone_data->isNSEC3Signed());
+    const ZoneData* zone_data =
+        client_->findZoneData(Name("example.org"));
+    ASSERT_NE(static_cast<const ZoneData*>(NULL), zone_data);
+    EXPECT_TRUE(zone_data->isSigned());
+    EXPECT_TRUE(zone_data->isNSEC3Signed());
 }
 
 TEST_F(MemoryClientTest, loadNSEC3SignedNoParam) {
     client_->load(Name("example.org"),
                   TEST_DATA_DIR "/example.org-nsec3-signed-no-param.zone");
-    isc::datasrc::memory::ZoneTable::FindResult
-        result(client_->findZoneData(Name("example.org")));
-    EXPECT_EQ(result::SUCCESS, result.code);
-    ASSERT_NE(static_cast<ZoneData*>(NULL),
-              result.zone_data);
-    EXPECT_TRUE(result.zone_data->isSigned());
-    EXPECT_TRUE(result.zone_data->isNSEC3Signed());
+    const ZoneData* zone_data =
+        client_->findZoneData(Name("example.org"));
+    ASSERT_NE(static_cast<const ZoneData*>(NULL), zone_data);
+    EXPECT_TRUE(zone_data->isSigned());
+    EXPECT_TRUE(zone_data->isNSEC3Signed());
 }
 
 TEST_F(MemoryClientTest, loadReloadZone) {