Browse Source

added -Wno-strict-aliasing to hide warning about boost::bind(function) warning
added a TODO for the open issues in ticket 43
updated doxygen for getSocket()


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1513 e5f2f494-b856-4b98-b285-d166d9295462

Jelte Jansen 15 years ago
parent
commit
1cd022f611
3 changed files with 19 additions and 1 deletions
  1. 1 1
      src/lib/config/Makefile.am
  2. 8 0
      src/lib/config/TODO
  3. 10 0
      src/lib/config/ccsession.h

+ 1 - 1
src/lib/config/Makefile.am

@@ -1,4 +1,4 @@
-AM_CPPFLAGS = -I$(top_srcdir)/src/lib -I$(top_builddir)/src/lib
+AM_CPPFLAGS = -I$(top_srcdir)/src/lib -I$(top_builddir)/src/lib -Wno-strict-aliasing
 AM_CPPFLAGS += -I$(top_srcdir)/ext
 
 lib_LTLIBRARIES = libcfgclient.la

+ 8 - 0
src/lib/config/TODO

@@ -0,0 +1,8 @@
+Open issues for lib/config:
+
+* Error output currently goes to stdout, and we need to use
+  decent logging for that.
+* Add "expect failure" tests to the unit tests.
+* This cpp version does not use recvmsg() with a sequence number to
+  prevent other messages sneaking in before the answer it expects.
+  (because lib/cc/session.cc|h does not support that yet).

+ 10 - 0
src/lib/config/ccsession.h

@@ -137,6 +137,16 @@ public:
                     isc::data::ElementPtr(*config_handler)(isc::data::ElementPtr new_config) = NULL,
                     isc::data::ElementPtr(*command_handler)(const std::string& command, const isc::data::ElementPtr args) = NULL
                     ) throw (isc::cc::SessionError);
+
+    /**
+     * Returns the socket that is used to communicate with the msgq
+     * command channel. This socket should *only* be used to run a
+     * select() loop over it. And if not time-critical, it is strongly
+     * recommended to only use checkCommand() to check for messages
+     *
+     * @return The socket used to communicate with the msgq command
+     *         channel.
+     */
     int getSocket();
 
     /**