Browse Source

[2545] Moved global storages to the anonymous namespace.

Marcin Siodelski 12 years ago
parent
commit
28a43fa59f
2 changed files with 8 additions and 7 deletions
  1. 6 0
      src/bin/dhcp4/config_parser.cc
  2. 2 7
      src/bin/dhcp4/config_parser.h

+ 6 - 0
src/bin/dhcp4/config_parser.cc

@@ -59,6 +59,12 @@ typedef Dhcp4ConfigParser* ParserFactory(const std::string& config_id);
 /// @brief a collection of factories that creates parsers for specified element names
 typedef std::map<std::string, ParserFactory*> FactoryMap;
 
+/// @brief a collection of elements that store uint32 values (e.g. renew-timer = 900)
+typedef std::map<std::string, uint32_t> Uint32Storage;
+
+/// @brief a collection of elements that store string values
+typedef std::map<std::string, std::string> StringStorage;
+
 /// @brief Storage for parsed boolean values.
 typedef std::map<string, bool> BooleanStorage;
 

+ 2 - 7
src/bin/dhcp4/config_parser.h

@@ -28,12 +28,6 @@ namespace dhcp {
 
 class Dhcpv4Srv;
 
-/// @brief a collection of elements that store uint32 values (e.g. renew-timer = 900)
-typedef std::map<std::string, uint32_t> Uint32Storage;
-
-/// @brief a collection of elements that store string values
-typedef std::map<std::string, std::string> StringStorage;
-
 /// An exception that is thrown if an error occurs while configuring an
 /// @c Dhcpv4Srv object.
 class Dhcp4ConfigError : public isc::Exception {
@@ -69,7 +63,8 @@ public:
 /// reconfiguration statuses. It may return the following response codes:
 /// 0 - configuration successful
 /// 1 - malformed configuration (parsing failed)
-/// 2 - logical error (parsing was successful, but the values are invalid)
+/// 2 - commit failed (parsing was successful, but failed to store the
+/// values in to server's configuration)
 ///
 /// @param config_set a new configuration (JSON) for DHCPv4 server
 /// @return answer that contains result of reconfiguration