[2445] minor cleanups: brace position, indent, use 'protected' in test class

src/lib/log/logger_manager_impl.cc

@@ -148,8 +148,7 @@ LoggerManagerImpl::createFileAppender(log4cplus::Logger& logger,
 }
 
 void
-LoggerManagerImpl::createBufferAppender(log4cplus::Logger& logger)
-{
+LoggerManagerImpl::createBufferAppender(log4cplus::Logger& logger) {
     log4cplus::SharedAppenderPtr bufferapp(new BufferAppender(getLogBuffer()));
     bufferapp->setName("buffer");
     logger.addAppender(bufferapp);

src/lib/log/logger_support.cc

@@ -46,7 +46,7 @@ setLoggingInitialized(bool state) {
 
 void
 initLogger(const string& root, isc::log::Severity severity, int dbglevel,
-    const char* file, bool buffer) {
+           const char* file, bool buffer) {
     LoggerManager::init(root, severity, dbglevel, file, buffer);
 }
 

src/lib/log/tests/log_buffer_unittest.cc

@@ -30,7 +30,7 @@ namespace isc {
 namespace log {
 
 class LogBufferTest : public ::testing::Test {
-public:
+protected:
     LogBufferTest() : appender1(new BufferAppender(buffer1)),
                       appender2(new BufferAppender(buffer2)),
                       logger(log4cplus::Logger::getInstance("buffer"))
@@ -49,7 +49,7 @@ public:
         buffer2.flush();
     }
 
-    void checkBufferedSize(LogBuffer& buffer, size_t expected) {
+    void checkBufferedSize(const LogBuffer& buffer, size_t expected) const {
         ASSERT_EQ(expected, buffer.stored_.size());
     }