Browse Source

[trac997] minor editorial fixes:
- add blank lines for readability
- remove white space for style consistency
- use "lower+underscore" style for variables (per the guideline)

JINMEI Tatuya 14 years ago
parent
commit
30a20a04aa
2 changed files with 20 additions and 15 deletions
  1. 8 3
      src/lib/acl/acl.h
  2. 12 12
      src/lib/acl/tests/acl_test.cc

+ 8 - 3
src/lib/acl/acl.h

@@ -59,6 +59,7 @@ private:
      * is created).
      */
     Acl(const Acl<Context, Action>& other);
+
     /**
      * \brief Assignment operator.
      *
@@ -67,7 +68,8 @@ private:
      * added (or, more correctly, this privade one removed so default one
      * is created).
      */
-    Acl& operator =(const Acl<Context, Action>& other);
+    Acl& operator=(const Acl<Context, Action>& other);
+
 public:
     /**
      * \brief Constructor.
@@ -76,7 +78,8 @@ public:
      *     "falls off" the end of the list (when no rule matched).
      */
     Acl(Action policy) : policy_(policy)
-    { }
+    {}
+
     /**
      * \brief Pointer to the check.
      *
@@ -85,6 +88,7 @@ public:
      * together in future).
      */
     typedef boost::shared_ptr<Check<Context> > CheckPtr;
+
     /**
      * \brief The actual main function that decides.
      *
@@ -97,13 +101,14 @@ public:
      */
     Action execute(const Context& context) const {
         for (typename Entries::const_iterator i(entries_.begin());
-             i != entries_.end(); ++ i) {
+             i != entries_.end(); ++i) {
             if (i->first->matches(context)) {
                 return (i->second);
             }
         }
         return (policy_);
     }
+
     /**
      * \brief Add new entry at the end of the list.
      *

+ 12 - 12
src/lib/acl/tests/acl_test.cc

@@ -41,14 +41,14 @@ struct Log {
             "of log";
         {
             SCOPED_TRACE("Checking that the first amount of checks did run");
-            for (size_t i(0); i < amount; ++ i) {
+            for (size_t i(0); i < amount; ++i) {
                 EXPECT_TRUE(run[i]) << "Check #" << i << " did not run.";
             }
         }
 
         {
             SCOPED_TRACE("Checking that the rest did not run");
-            for (size_t i(amount); i < LOG_SIZE; ++ i) {
+            for (size_t i(amount); i < LOG_SIZE; ++i) {
                 EXPECT_FALSE(run[i]) << "Check #" << i << "did run.";
             }
         }
@@ -59,19 +59,19 @@ struct Log {
 // But it logs that it did run.
 class ConstCheck : public Check<Log*> {
 public:
-    ConstCheck(bool accepts, size_t logNum) :
-        logNum_(logNum),
+    ConstCheck(bool accepts, size_t log_num) :
+        log_num_(log_num),
         accepts_(accepts)
     {
-        assert(logNum < LOG_SIZE); // If this fails, the LOG_SIZE is too small
+        assert(log_num < LOG_SIZE); // If this fails, the LOG_SIZE is too small
     }
     typedef Log* LPtr;
     virtual bool matches(const LPtr& log) const {
-        log->run[logNum_] = true;
+        log->run[log_num_] = true;
         return (accepts_);
     }
 private:
-    size_t logNum_;
+    size_t log_num_;
     bool accepts_;
 };
 
@@ -81,7 +81,7 @@ class TestAcl : public Acl<Log*> {
 public:
     TestAcl() :
         Acl(DROP)
-    { }
+    {}
     // Check the stored policy there
     void checkPolicy(Action ac) {
         EXPECT_EQ(policy_, ac);
@@ -93,14 +93,14 @@ public:
 class AclTest : public ::testing::Test {
 public:
     AclTest() :
-        nextCheck_(0)
-    { }
+        next_check_(0)
+    {}
     TestAcl acl_;
     Log log_;
-    size_t nextCheck_;
+    size_t next_check_;
     shared_ptr<Check<Log*> > getCheck(bool accepts) {
         return (shared_ptr<Check<Log*> >(new ConstCheck(accepts,
-                                                        nextCheck_ ++)));
+                                                        next_check_++)));
     }
 };