Browse Source

[5077] Addressed two additional review comments.

- Type cast to char, rather than uint8_t
- Return tag in the doxygen documentation
Marcin Siodelski 8 years ago
parent
commit
31594fda81
2 changed files with 4 additions and 2 deletions
  1. 2 0
      src/lib/http/request.h
  2. 2 2
      src/lib/http/request_parser.cc

+ 2 - 0
src/lib/http/request.h

@@ -78,6 +78,8 @@ public:
     ///
     /// This method is called by the @ref HttpRequestParser to retrieve the
     /// context in which parsed data is stored.
+    ///
+    /// @return Pointer to the underlying @ref HttpRequestContext.
     const HttpRequestContextPtr& context() const {
         return (context_);
     }

+ 2 - 2
src/lib/http/request_parser.cc

@@ -97,8 +97,8 @@ HttpRequestParser::postBuffer(const void* buf, const size_t buf_size) {
         if (getNextEvent() == NEED_MORE_DATA_EVT) {
             transition(getCurrState(), MORE_DATA_PROVIDED_EVT);
         }
-        buffer_.insert(buffer_.end(), static_cast<const uint8_t*>(buf),
-                       static_cast<const uint8_t*>(buf) + buf_size);
+        buffer_.insert(buffer_.end(), static_cast<const char*>(buf),
+                       static_cast<const char*>(buf) + buf_size);
     }
 }