Parcourir la source

[trac3576] Updates per review comments

Typo level changes per review comments.
Shawn Routhier il y a 9 ans
Parent
commit
33f0882b59

+ 8 - 0
ChangeLog

@@ -1,3 +1,11 @@
+101x.   [func]		sar
+	Added support for several options for use by PXE.
+	From RFC4578 (for DHCPv4) these are: 93 - client-system,
+	94 - client-ndi, 97 - uuid-guid.
+	From RFC5970 (for  DHCPv6) these are: 59 - bootfile-url,
+	60 - bootfile-param, 61 - client-arch-type, 62 - nii.
+	(trac #3576, git <TBD>)
+
 1011.	[func]		fdupont
 1011.	[func]		fdupont
 	Added definitions and tests for the options from secure DHCPv6.
 	Added definitions and tests for the options from secure DHCPv6.
 	This protocol is still experimental. The option and other protocol
 	This protocol is still experimental. The option and other protocol

+ 3 - 3
src/lib/dhcp/option_opaque_data_tuples.h

@@ -107,9 +107,9 @@ public:
 
 
     /// @brief Returns opaque data tuple at the specified position.
     /// @brief Returns opaque data tuple at the specified position.
     ///
     ///
-    ///  If the specified position is out of range an exception is thrown.
+    /// If the specified position is out of range an exception is thrown.
     ///
     ///
-    /// @param at Index at which the tuple should be replaced.
+    /// @param at Index for which tuple to get.
     /// @throw isc::OutOfRange if the tuple position is out of range.
     /// @throw isc::OutOfRange if the tuple position is out of range.
     OpaqueDataTuple getTuple(const size_t at) const;
     OpaqueDataTuple getTuple(const size_t at) const;
 
 
@@ -123,7 +123,7 @@ public:
         return (tuples_);
         return (tuples_);
     }
     }
 
 
-    /// @brief Checks if the object  holds the opaque data tuple with the
+    /// @brief Checks if the object holds the opaque data tuple with the
     /// specified string.
     /// specified string.
     ///
     ///
     /// @param tuple_str String representation of the tuple being searched.
     /// @param tuple_str String representation of the tuple being searched.

+ 2 - 2
src/lib/dhcp/option_vendor_class.h

@@ -119,9 +119,9 @@ public:
 
 
     /// @brief Returns opaque data tuple at the specified position.
     /// @brief Returns opaque data tuple at the specified position.
     ///
     ///
-    ///  If the specified position is out of range an exception is thrown.
+    /// If the specified position is out of range an exception is thrown.
     ///
     ///
-    /// @param at Index at which the tuple should be replaced.
+    /// @param at Index for which tuple to get.
     /// @throw isc::OutOfRange if the tuple position is out of range.
     /// @throw isc::OutOfRange if the tuple position is out of range.
     OpaqueDataTuple getTuple(const size_t at) const;
     OpaqueDataTuple getTuple(const size_t at) const;
 
 

+ 1 - 1
src/lib/dhcp/tests/libdhcp++_unittest.cc

@@ -1179,7 +1179,7 @@ TEST_F(LibDhcpTest, stdOptionDefs6) {
                                     typeid(Option6AddrLst));
                                     typeid(Option6AddrLst));
 
 
     LibDhcpTest::testStdOptionDefs6(D6O_BOOTFILE_URL, begin, end,
     LibDhcpTest::testStdOptionDefs6(D6O_BOOTFILE_URL, begin, end,
-				    typeid(OptionString));
+                                    typeid(OptionString));
 
 
     LibDhcpTest::testStdOptionDefs6(D6O_BOOTFILE_PARAM, bparam_buf.begin(),
     LibDhcpTest::testStdOptionDefs6(D6O_BOOTFILE_PARAM, bparam_buf.begin(),
                                     bparam_buf.end(),
                                     bparam_buf.end(),

+ 1 - 1
src/lib/dhcp/tests/option_opaque_data_tuples_unittest.cc

@@ -215,7 +215,7 @@ TEST(OptionOpaqueDataTuples, unpack6NoTuple) {
     // Prepare data to decode.
     // Prepare data to decode.
     const uint8_t buf_data[] = {
     const uint8_t buf_data[] = {
     };
     };
-    OptionBuffer buf(buf_data,buf_data + sizeof(buf_data));
+    OptionBuffer buf(buf_data, buf_data + sizeof(buf_data));
 
 
     OptionOpaqueDataTuplesPtr data_tuple;
     OptionOpaqueDataTuplesPtr data_tuple;
     ASSERT_NO_THROW(
     ASSERT_NO_THROW(