Parcourir la source

[5324] Upped the default log size to 10MB

Thomas Markwalder il y a 7 ans
Parent
commit
3493d04122

+ 2 - 2
doc/guide/logging.xml

@@ -635,8 +635,8 @@
             is renamed ".2", etc. This is referred to as rotation.
           </para>
           <para>
-            The default value is 204800. This is also the smallest value that
-            may be specified without disabling rotation.  Any value less than
+            The default value is 10240000 (10MB).  The smallest value that may
+            be specified without disabling rotation is 204800. Any value less than
             this, including 0, disables rotation.
           </para>
           <note>

+ 1 - 1
src/lib/dhcpsrv/logging_info.h

@@ -45,7 +45,7 @@ struct LoggingDestination : public isc::data::CfgToElement {
 
     /// @brief Default constructor.
     LoggingDestination()
-        : output_("stdout"), maxver_(1), maxsize_(204800), flush_(true) {
+        : output_("stdout"), maxver_(1), maxsize_(10240000), flush_(true) {
     }
 
     /// @brief Unparse a configuration object

+ 2 - 2
src/lib/dhcpsrv/tests/logging_info_unittest.cc

@@ -74,7 +74,7 @@ TEST_F(LoggingInfoTest, defaults) {
     std::string header = "{\n"
         "\"name\": \"kea\",\n"
         "\"output_options\": [ {\n"
-        " \"output\": \"stdout\",\n \"maxsize\": 204800,\n"
+        " \"output\": \"stdout\",\n \"maxsize\": 10240000,\n"
         " \"maxver\": 1,\n \"flush\": true } ],\n"
         "\"severity\": \"";
     std::string dbglvl = "\",\n\"debuglevel\": ";
@@ -91,7 +91,7 @@ TEST_F(LoggingInfoTest, defaults) {
     ASSERT_EQ(1, info_verbose.destinations_.size());
     EXPECT_EQ("stdout", info_verbose.destinations_[0].output_);
 
-    EXPECT_EQ(204800, info_verbose.destinations_[0].maxsize_);
+    EXPECT_EQ(10240000, info_verbose.destinations_[0].maxsize_);
     EXPECT_EQ(1, info_verbose.destinations_[0].maxver_);
 
     expected = header + "DEBUG" + dbglvl + "99" + trailer;

+ 1 - 1
src/lib/dhcpsrv/tests/logging_unittest.cc

@@ -73,7 +73,7 @@ class LoggingTest : public ::testing::Test {
 };
 
 const char* LoggingTest::TEST_LOG_NAME = "kea.test.log";
-const int LoggingTest::TEST_MAX_SIZE = 207800;  // Slightly larger than default
+const int LoggingTest::TEST_MAX_SIZE = 204800;  // Smallest without disabling rotation 
 const int LoggingTest::TEST_MAX_VERS = 2;       // More than the default of 1
 
 // Tests that the spec file is valid.