Parcourir la source

[3086] Added todo comment regarding default constructor use.

Thomas Markwalder il y a 11 ans
Parent
commit
351b73dcc7
1 fichiers modifiés avec 8 ajouts et 0 suppressions
  1. 8 0
      src/lib/dhcp_ddns/ncr_msg.h

+ 8 - 0
src/lib/dhcp_ddns/ncr_msg.h

@@ -156,6 +156,14 @@ typedef std::map<std::string, isc::data::ConstElementPtr> ElementMap;
 class NameChangeRequest {
 public:
     /// @brief Default Constructor.
+    ///
+    /// @todo Currently, fromWire makes use of the ability to create an empty
+    /// NameChangeRequest and then builds it bit by bit.  This means that it
+    /// is technically possible to create one and attempt to use in ways
+    /// other than intended and its invalid content may or may not be handled
+    /// gracefully by consuming code.  It might be wise to revisit this
+    /// structuring such that we do not use a default constructor and only
+    /// allow valid instantiations.
     NameChangeRequest();
 
     /// @brief Constructor.  Full constructor, which provides parameters for