Browse Source

[3673] Fixed cppcheck errors in the MySQL and PgSQL backends.

This is about making some functions static or const.
Marcin Siodelski 10 years ago
parent
commit
3ec0536917
2 changed files with 5 additions and 4 deletions
  1. 4 3
      src/lib/dhcpsrv/mysql_lease_mgr.cc
  2. 1 1
      src/lib/dhcpsrv/pgsql_lease_mgr.cc

+ 4 - 3
src/lib/dhcpsrv/mysql_lease_mgr.cc

@@ -240,7 +240,8 @@ public:
     ///        data associated with one of the "bind" elements, the
     ///        corresponding element in the error array is set to MLM_TRUE.
     /// @param count Size of each of the arrays.
-    void setErrorIndicators(MYSQL_BIND* bind, my_bool* error, size_t count) {
+    static void setErrorIndicators(MYSQL_BIND* bind, my_bool* error,
+                                   size_t count) {
         for (size_t i = 0; i < count; ++i) {
             error[i] = MLM_FALSE;
             bind[i].error = reinterpret_cast<char*>(&error[i]);
@@ -260,8 +261,8 @@ public:
     ///        the error.
     /// @param names Array of column names, the same size as the error array.
     /// @param count Size of each of the arrays.
-    std::string getColumnsInError(my_bool* error, std::string* names,
-                                  size_t count) {
+    static std::string getColumnsInError(my_bool* error, std::string* names,
+                                         size_t count) {
         std::string result = "";
 
         // Accumulate list of column names

+ 1 - 1
src/lib/dhcpsrv/pgsql_lease_mgr.cc

@@ -508,7 +508,7 @@ public:
     }
 
     /// @brief Returns column label given a column number
-    std::string getColumnLabel(const size_t column) {
+    std::string getColumnLabel(const size_t column) const {
         if (column > columnLabels_.size()) {
             ostringstream os;
             os << "Unknown column:" << column;