Parcourir la source

[1259] Comment what the compact method really does

The way it compacts is explained.
Michal 'vorner' Vaner il y a 13 ans
Parent
commit
48d5ac5927
1 fichiers modifiés avec 6 ajouts et 2 suppressions
  1. 6 2
      src/lib/python/isc/xfrin/diff.py

+ 6 - 2
src/lib/python/isc/xfrin/diff.py

@@ -108,9 +108,13 @@ class Diff:
         Tries to compact the operations in buffer a little by putting some of
         the operations together, forming RRsets with more than one RR.
 
-        This is called by apply before putting the data into datasource.
+        This is called by apply before putting the data into datasource. You
+        may, but not have to, call this manually.
 
-        It is currently empty and needs implementing.
+        Currently it merges consecutive same operations on the same
+        domain/type. We could do more fancy things, like sorting by the domain
+        and do more merging, but such diffs should be rare in practice anyway,
+        so we don't bother and do it this simple way.
         """
         pass