Browse Source

[530] Do not redirect b10-msgq STDOUT when running in verbose mode

When bind10 is run in verbose mode, as is indicated to the user by
certain error messages, do not redirect b10-msgq's STDOUT to /dev/null
so that the user can see the actual cause for startup failure.

No ChangeLog entry required.
Kean Johnston 11 years ago
parent
commit
495195f672
2 changed files with 2 additions and 2 deletions
  1. 1 1
      src/bin/bind10/init.py.in
  2. 1 1
      src/bin/bind10/tests/init_test.py.in

+ 1 - 1
src/bin/bind10/init.py.in

@@ -490,7 +490,7 @@ class Init:
         self.log_starting("b10-msgq")
         msgq_proc = self._make_process_info("b10-msgq", ["b10-msgq"],
                                             self.c_channel_env,
-                                            True, not self.verbose)
+                                            not self.verbose, not self.verbose)
         msgq_proc.spawn()
         self.log_started(msgq_proc.pid)
 

+ 1 - 1
src/bin/bind10/tests/init_test.py.in

@@ -1651,7 +1651,7 @@ class TestInitComponents(unittest.TestCase):
         pi = init.start_msgq()
         self.assertEqual('b10-msgq', pi.name)
         self.assertEqual(['b10-msgq'], pi.args)
-        self.assertTrue(pi.dev_null_stdout)
+        self.assertEqual(pi.dev_null_stdout, not verbose)
         self.assertEqual(pi.dev_null_stderr, not verbose)
         self.assertEqual({'FOO': 'an env string'}, pi.env)