Browse Source

[master] Adding a comment marking readPsid & co issue origin

Francis Dupont 8 years ago
parent
commit
54a2693ff7

+ 1 - 0
src/lib/dhcp/tests/option_custom_unittest.cc

@@ -99,6 +99,7 @@ public:
     /// @tparam integer type.
     /// @tparam integer type.
     template<typename T>
     template<typename T>
     void writeInt(T value, std::vector<uint8_t>& buf) {
     void writeInt(T value, std::vector<uint8_t>& buf) {
+        // This loop is incorrectly compiled by some old g++?!
         for (int i = 0; i < sizeof(T); ++i) {
         for (int i = 0; i < sizeof(T); ++i) {
             buf.push_back(value >> ((sizeof(T) - i - 1) * 8) & 0xFF);
             buf.push_back(value >> ((sizeof(T) - i - 1) * 8) & 0xFF);
         }
         }

+ 1 - 0
src/lib/dhcp/tests/option_data_types_unittest.cc

@@ -44,6 +44,7 @@ public:
     /// @tparam integer type.
     /// @tparam integer type.
     template<typename T>
     template<typename T>
     void writeInt(T value, std::vector<uint8_t>& buf) {
     void writeInt(T value, std::vector<uint8_t>& buf) {
+        // This loop is incorrectly compiled by some old g++?!
         for (int i = 0; i < sizeof(T); ++i) {
         for (int i = 0; i < sizeof(T); ++i) {
             buf.push_back(value >> ((sizeof(T) - i - 1) * 8) & 0xFF);
             buf.push_back(value >> ((sizeof(T) - i - 1) * 8) & 0xFF);
         }
         }