Browse Source

[1555] Minor: added a todo comment.

Marcin Siodelski 11 years ago
parent
commit
6b65ea8a61
2 changed files with 4 additions and 0 deletions
  1. 2 0
      src/bin/dhcp4/dhcp4_srv.cc
  2. 2 0
      src/bin/dhcp6/dhcp6_srv.cc

+ 2 - 0
src/bin/dhcp4/dhcp4_srv.cc

@@ -852,6 +852,8 @@ Dhcpv4Srv::openActiveSockets(const uint16_t port,
     }
     // Let's reopen active sockets. openSockets4 will check internally whether
     // sockets are marked active or inactive.
+    // @todo Optimization: we should not reopen all sockets but rather select
+    // those that have been affected by the new configuration.
     if (!IfaceMgr::instance().openSockets4(port, use_bcast)) {
         LOG_WARN(dhcp4_logger, DHCP4_NO_SOCKETS_OPEN);
     }

+ 2 - 0
src/bin/dhcp6/dhcp6_srv.cc

@@ -1133,6 +1133,8 @@ Dhcpv6Srv::openActiveSockets(const uint16_t port) {
     }
     // Let's reopen active sockets. openSockets6 will check internally whether
     // sockets are marked active or inactive.
+    // @todo Optimization: we should not reopen all sockets but rather select
+    // those that have been affected by the new configuration.
     if (!IfaceMgr::instance().openSockets6(port)) {
         LOG_WARN(dhcp6_logger, DHCP6_NO_SOCKETS_OPEN);
     }