Browse Source

preferred EXPECT_EQ(a,b) to EXPECT_TRUE(a==b) because on failure we can see
the vlaues of a and b


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1006 e5f2f494-b856-4b98-b285-d166d9295462

JINMEI Tatuya 15 years ago
parent
commit
6e331c4d33
1 changed files with 5 additions and 5 deletions
  1. 5 5
      src/lib/dns/cpp/tests/rrsetlist_unittest.cc

+ 5 - 5
src/lib/dns/cpp/tests/rrsetlist_unittest.cc

@@ -107,19 +107,19 @@ TEST_F(RRsetListTest, randomAccess) {
     RRsetPtr p;
     RRsetPtr p;
 
 
     p = list[RRType::CNAME()];
     p = list[RRType::CNAME()];
-    EXPECT_TRUE(p->getType() == RRType::CNAME());
+    EXPECT_EQ(p->getType(), RRType::CNAME());
 
 
     p = list[RRType::AAAA()];
     p = list[RRType::AAAA()];
-    EXPECT_TRUE(p->getType() == RRType::AAAA());
+    EXPECT_EQ(p->getType(), RRType::AAAA());
 
 
     p = list[RRType::NS()];
     p = list[RRType::NS()];
-    EXPECT_TRUE(p->getType() == RRType::NS());
+    EXPECT_EQ(p->getType(), RRType::NS());
 
 
     p = list[RRType::A()];
     p = list[RRType::A()];
-    EXPECT_TRUE(p->getType() == RRType::A());
+    EXPECT_EQ(p->getType(), RRType::A());
 
 
     p = list[RRType::SOA()];
     p = list[RRType::SOA()];
-    EXPECT_TRUE(p->getType() == RRType::SOA());
+    EXPECT_EQ(p->getType(), RRType::SOA());
 }
 }
 
 
 TEST_F(RRsetListTest, findRRset) {
 TEST_F(RRsetListTest, findRRset) {