Browse Source

[2435] Check result of find() in test

JINMEI Tatuya 12 years ago
parent
commit
72383e8959
1 changed files with 7 additions and 5 deletions
  1. 7 5
      src/lib/datasrc/tests/database_unittest.cc

+ 7 - 5
src/lib/datasrc/tests/database_unittest.cc

@@ -4390,11 +4390,13 @@ TYPED_TEST(RRsetCollectionAndUpdaterTest, updateThrows) {
     this->updater_.reset();
     this->updater_ = this->client_->getUpdater(this->zname_, false);
 
-    // Just call getRRsetCollection() here. The .find() is unnecessary,
-    // but we have it to use the result of getRRsetCollection().
-    this->updater_->getRRsetCollection().find(Name("www.example.org"),
-                                              RRClass::IN(),
-                                              RRType::MX());
+    // Just call getRRsetCollection() here. The test using .find() is
+    // unnecessary for the purpose of this test case, but we have it to
+    // use the result of getRRsetCollection() and silence some compiler
+    // complaining about ignoring the return value of
+    // getRRsetCollection().
+    EXPECT_FALSE(this->updater_->getRRsetCollection().
+                 find(Name("www.example.org"), RRClass::IN(), RRType::MX()));
 
     // addRRset() must throw isc::InvalidOperation here.
     EXPECT_THROW(this->updater_->addRRset(*this->rrset_),