Browse Source

[1924] Use the constants in default parameters too

Michal 'vorner' Vaner 12 years ago
parent
commit
7377c385cd
3 changed files with 12 additions and 10 deletions
  1. 0 2
      src/lib/cc/session.cc
  2. 10 6
      src/lib/cc/session.h
  3. 2 2
      src/lib/python/isc/cc/session.py

+ 0 - 2
src/lib/cc/session.cc

@@ -33,8 +33,6 @@
 #include <cc/data.h>
 #include <cc/data.h>
 #include <cc/session.h>
 #include <cc/session.h>
 
 
-#include <util/common_defs.h>
-
 #include <cstdio>
 #include <cstdio>
 #include <vector>
 #include <vector>
 #include <iostream>
 #include <iostream>

+ 10 - 6
src/lib/cc/session.h

@@ -15,14 +15,16 @@
 #ifndef ISC_SESSION_H
 #ifndef ISC_SESSION_H
 #define ISC_SESSION_H 1
 #define ISC_SESSION_H 1
 
 
-#include <string>
+#include <cc/data.h>
+#include <cc/session_config.h>
 
 
-#include <boost/function.hpp>
+#include <util/common_defs.h>
 
 
 #include <exceptions/exceptions.h>
 #include <exceptions/exceptions.h>
 
 
-#include <cc/data.h>
-#include <cc/session_config.h>
+#include <string>
+
+#include <boost/function.hpp>
 
 
 namespace asio {
 namespace asio {
 class io_service;
 class io_service;
@@ -81,8 +83,10 @@ namespace isc {
             virtual void disconnect() = 0;
             virtual void disconnect() = 0;
             virtual int group_sendmsg(isc::data::ConstElementPtr msg,
             virtual int group_sendmsg(isc::data::ConstElementPtr msg,
                                       std::string group,
                                       std::string group,
-                                      std::string instance = "*",
-                                      std::string to = "*",
+                                      std::string instance =
+                                          isc::util::CC_INSTANCE_WILDCARD,
+                                      std::string to =
+                                          isc::util::CC_TO_WILDCARD,
                                       bool want_answer = false) = 0;
                                       bool want_answer = false) = 0;
             virtual bool group_recvmsg(isc::data::ConstElementPtr& envelope,
             virtual bool group_recvmsg(isc::data::ConstElementPtr& envelope,
                                        isc::data::ConstElementPtr& msg,
                                        isc::data::ConstElementPtr& msg,

+ 2 - 2
src/lib/python/isc/cc/session.py

@@ -257,8 +257,8 @@ class Session:
             "instance": instance,
             "instance": instance,
         })
         })
 
 
-    def group_sendmsg(self, msg, group, instance = "*", to = "*",
-                      want_answer=False):
+    def group_sendmsg(self, msg, group, instance=CC_INSTANCE_WILDCARD,
+                      to=CC_TO_WILDCARD, want_answer=False):
         seq = self._next_sequence()
         seq = self._next_sequence()
         self.sendmsg({
         self.sendmsg({
             CC_HEADER_TYPE: CC_COMMAND_SEND,
             CC_HEADER_TYPE: CC_COMMAND_SEND,