Browse Source

added notes about r2040 and r2041.

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2042 e5f2f494-b856-4b98-b285-d166d9295462
JINMEI Tatuya 15 years ago
parent
commit
7fd72bcd62

+ 2 - 0
src/lib/datasrc/tests/sqlite3_unittest.cc

@@ -376,6 +376,8 @@ TEST_F(Sqlite3DataSourceTest, reOpen) {
 
 
     NameMatch name_match(www_name);
     NameMatch name_match(www_name);
     data_source.findClosestEnclosure(name_match, rrclass);
     data_source.findClosestEnclosure(name_match, rrclass);
+    // XXX: some deviant compilers seem to fail to recognize a NULL as a
+    // pointer type.  This explicit cast works around such compilers.
     EXPECT_EQ(static_cast<void*>(NULL), name_match.closestName());
     EXPECT_EQ(static_cast<void*>(NULL), name_match.closestName());
     EXPECT_EQ(static_cast<void*>(NULL), name_match.bestDataSrc());
     EXPECT_EQ(static_cast<void*>(NULL), name_match.bestDataSrc());
 }
 }

+ 1 - 0
src/lib/datasrc/tests/static_unittest.cc

@@ -214,6 +214,7 @@ TEST_F(StaticDataSourceTest, findClosestEnclosureForVersionClassAny) {
 TEST_F(StaticDataSourceTest, findClosestEnclosureForVersionClassMismatch) {
 TEST_F(StaticDataSourceTest, findClosestEnclosureForVersionClassMismatch) {
     NameMatch name_match(version_name);
     NameMatch name_match(version_name);
     data_source.findClosestEnclosure(name_match, RRClass::IN());
     data_source.findClosestEnclosure(name_match, RRClass::IN());
+    // XXX: see sqlite3_unittest.cc about the cast.
     EXPECT_EQ(static_cast<void*>(NULL), name_match.closestName());
     EXPECT_EQ(static_cast<void*>(NULL), name_match.closestName());
     EXPECT_EQ(static_cast<void*>(NULL), name_match.bestDataSrc());
     EXPECT_EQ(static_cast<void*>(NULL), name_match.bestDataSrc());
 }
 }