Browse Source

[trac534] updated comments about NS check in cutCallback().

JINMEI Tatuya 14 years ago
parent
commit
83904ae5b5
1 changed files with 6 additions and 4 deletions
  1. 6 4
      src/lib/datasrc/memory_datasrc.cc

+ 6 - 4
src/lib/datasrc/memory_datasrc.cc

@@ -230,10 +230,12 @@ struct MemoryZone::MemoryZoneImpl {
         const Domain::const_iterator foundNS(node.getData()->find(
         const Domain::const_iterator foundNS(node.getData()->find(
             RRType::NS()));
             RRType::NS()));
         if (foundNS != node.getData()->end()) {
         if (foundNS != node.getData()->end()) {
-            // BIND 9 checks if this node is not the origin.  But it cannot
-            // be the origin because we don't enable the callback at the
-            // origin node (see MemoryZoneImpl::add()).  Or should we do a
-            // double check for it?
+            // BIND 9 checks if this node is not the origin.  That's probably
+            // because it can support multiple versions for dynamic updates
+            // and IXFR, and it's possible that the callback is called at
+            // the apex and the DNAME doesn't exist for a particular version.
+            // It cannot happen for us (at least for now), so we don't do
+            // that check.
             state->zonecut_node_ = &node;
             state->zonecut_node_ = &node;
             state->rrset_ = foundNS->second;
             state->rrset_ = foundNS->second;