Browse Source

[2353] Test that the socket and tmpdir are deleted

Mukund Sivaraman 12 years ago
parent
commit
83d4f414a2
2 changed files with 8 additions and 8 deletions
  1. 4 5
      src/bin/bind10/bind10_src.py.in
  2. 4 3
      src/bin/bind10/tests/bind10_test.py.in

+ 4 - 5
src/bin/bind10/bind10_src.py.in

@@ -914,11 +914,10 @@ class BoB:
         """
         if self._srv_socket is not None:
             self._srv_socket.close()
-            os.remove(self._socket_path)
-            os.rmdir(self._tmpdir)
-            self._srv_socket = None
-            self._tmpdir = None
-            self._socket_path = None
+            if os.path.exists(self._socket_path):
+                os.remove(self._socket_path)
+            if os.path.isdir(self._tmpdir):
+                os.rmdir(self._tmpdir)
 
     def _srv_accept(self):
         """

+ 4 - 3
src/bin/bind10/tests/bind10_test.py.in

@@ -378,6 +378,7 @@ class TestBoB(unittest.TestCase):
         bob.init_socket_srv()
 
         self.assertIsNotNone(bob._srv_socket)
+        self.assertNotEqual(-1, bob._srv_socket.fileno())
         self.assertIsNotNone(bob._tmpdir)
         self.assertTrue(os.path.isdir(bob._tmpdir))
         self.assertIsNotNone(bob._socket_path)
@@ -385,9 +386,9 @@ class TestBoB(unittest.TestCase):
 
         bob.remove_socket_srv()
 
-        self.assertIsNone(bob._srv_socket)
-        self.assertIsNone(bob._tmpdir)
-        self.assertIsNone(bob._socket_path)
+        self.assertEqual(-1, bob._srv_socket.fileno())
+        self.assertFalse(os.path.exists(bob._socket_path))
+        self.assertFalse(os.path.isdir(bob._tmpdir))
 
     def test_init_alternate_socket(self):
         bob = BoB("alt_socket_file")