Browse Source

[4091] Better odd check

Francis Dupont 9 years ago
parent
commit
85a118414f
2 changed files with 2 additions and 2 deletions
  1. 1 1
      src/lib/dhcpsrv/parsers/dhcp_parsers.cc
  2. 1 1
      src/lib/eval/token.cc

+ 1 - 1
src/lib/dhcpsrv/parsers/dhcp_parsers.cc

@@ -593,7 +593,7 @@ OptionDataParser::createOption(ConstElementPtr option_data) {
             // The decodeHex function expects that the string contains an
             // even number of digits. If we don't meet this requirement,
             // we have to insert a leading 0.
-            if (!data_param.empty() && data_param.length() % 2) {
+            if (!data_param.empty() && ((data_param.length() % 2) != 0)) {
                 data_param = data_param.insert(0, "0");
             }
             util::encode::decodeHex(data_param, binary);

+ 1 - 1
src/lib/eval/token.cc

@@ -41,7 +41,7 @@ TokenHexString::evaluate(const Pkt& /*pkt*/, ValueStack& values) {
         // The decodeHex function expects that the string contains an
         // even number of digits. If we don't meet this requirement,
         // we have to insert a leading 0.
-        if (repr_.length() % 2) {
+        if ((repr_.length() % 2) != 0) {
             repr_ = repr_.insert(0, "0");
         }
         util::encode::decodeHex(repr_, binary);