Parcourir la source

[2292] minor cleanups: constify, indentation

JINMEI Tatuya il y a 12 ans
Parent
commit
869d14d705

+ 5 - 5
src/lib/datasrc/memory/memory_client.cc

@@ -627,11 +627,11 @@ InMemoryClient::InMemoryClientImpl::load(
     // node must point to a valid node now
     // node must point to a valid node now
     assert(node != NULL);
     assert(node != NULL);
 
 
-    std::string* tstr = node->setData(new std::string(filename));
+    const std::string* tstr = node->setData(new std::string(filename));
     delete tstr;
     delete tstr;
 
 
-    result::Result result(zone_table_->addZone(mem_sgmt_, rrclass_,
-                                               zone_name, holder));
+    const result::Result result(zone_table_->addZone(mem_sgmt_, rrclass_,
+                                                     zone_name, holder));
     if (result == result::SUCCESS) {
     if (result == result::SUCCESS) {
         // Only increment the zone count if the zone doesn't already
         // Only increment the zone count if the zone doesn't already
         // exist.
         // exist.
@@ -726,8 +726,8 @@ InMemoryClient::load(const isc::dns::Name& zone_name,
 const std::string
 const std::string
 InMemoryClient::getFileName(const isc::dns::Name& zone_name) const {
 InMemoryClient::getFileName(const isc::dns::Name& zone_name) const {
     const FileNameNode* node(NULL);
     const FileNameNode* node(NULL);
-    FileNameTree::Result result = impl_->file_name_tree_->find(zone_name,
-                                                               &node);
+    const FileNameTree::Result result = impl_->file_name_tree_->find(zone_name,
+                                                                     &node);
     if (result == FileNameTree::EXACTMATCH) {
     if (result == FileNameTree::EXACTMATCH) {
         return (*node->getData());
         return (*node->getData());
     } else {
     } else {

+ 1 - 1
src/lib/datasrc/tests/memory/domaintree_unittest.cc

@@ -414,7 +414,7 @@ performCallbackTest(TestDomainTree& dtree,
     // "cdtnode" may be invalid due to the insertion, so we need to re-find
     // "cdtnode" may be invalid due to the insertion, so we need to re-find
     // it.
     // it.
     EXPECT_EQ(TestDomainTree::EXACTMATCH, dtree.find(Name("callback.example"),
     EXPECT_EQ(TestDomainTree::EXACTMATCH, dtree.find(Name("callback.example"),
-                                                   &cdtnode));
+                                                     &cdtnode));
     EXPECT_TRUE(cdtnode->getFlag(TestDomainTreeNode::FLAG_CALLBACK));
     EXPECT_TRUE(cdtnode->getFlag(TestDomainTreeNode::FLAG_CALLBACK));
     EXPECT_FALSE(subdtnode->getFlag(TestDomainTreeNode::FLAG_CALLBACK));
     EXPECT_FALSE(subdtnode->getFlag(TestDomainTreeNode::FLAG_CALLBACK));
     EXPECT_FALSE(parentdtnode->getFlag(TestDomainTreeNode::FLAG_CALLBACK));
     EXPECT_FALSE(parentdtnode->getFlag(TestDomainTreeNode::FLAG_CALLBACK));