Browse Source

[2559] Address review comments

Stephen Morris 12 years ago
parent
commit
aad83b6edd

+ 0 - 3
src/bin/dhcp4/config_parser.cc

@@ -38,9 +38,6 @@ using namespace isc::asiolink;
 
 namespace {
 
-/// @brief auxiliary type used for storing element name and its parser
-typedef pair<string, ConstElementPtr> ConfigPair;
-
 /// @brief a factory method that will create a parser for a given element name
 typedef isc::dhcp::DhcpConfigParser* ParserFactory(const std::string& config_id);
 

+ 0 - 3
src/bin/dhcp6/config_parser.cc

@@ -47,9 +47,6 @@ using namespace isc::asiolink;
 
 namespace {
 
-/// @brief Auxiliary type used for storing an element name and its parser.
-typedef pair<string, ConstElementPtr> ConfigPair;
-
 /// @brief Factory method that will create a parser for a given element name
 typedef isc::dhcp::DhcpConfigParser* ParserFactory(const std::string& config_id);
 

+ 4 - 0
src/lib/dhcpsrv/tests/dbaccess_parser_unittest.cc

@@ -177,6 +177,10 @@ public:
     virtual ~TestDbAccessParser()
     {}
 
+    /// Allow use of superclass's protected functions.
+    using DbAccessParser::getDbAccessParameters;
+    using DbAccessParser::getDbAccessString;
+
     /// @brief Get database access parameters
     ///
     /// Used in testing to check that the configuration information has been