Parcourir la source

[trac614] Comments

Michal 'vorner' Vaner il y a 14 ans
Parent
commit
ae0b20c57c
2 fichiers modifiés avec 9 ajouts et 2 suppressions
  1. 2 2
      tools/tests_in_valgrind.sh
  2. 7 0
      tools/valgrind_test_cleaner.pl

+ 2 - 2
tools/tests_in_valgrind.sh

@@ -22,7 +22,7 @@
 make
 make
 
 
 if [ $? = 2 ] ; then
 if [ $? = 2 ] ; then
-    echo "Did you run configure? Do you call me from the top bind10 directory?" >&2
+    echo "Did you run configure? Or maybe you're running the script from the tools directory? (you need to run it from the top bind10 build directory)"
     exit 1
     exit 1
 fi
 fi
 
 
@@ -70,6 +70,6 @@ if test -n "$FAILED"; then
 fi
 fi
 
 
 if ! $FOUND_ANY ; then
 if ! $FOUND_ANY ; then
-    echo "No test was found. It is possible you configured witouth --with-gtest or you run it from wrong directory" >&2
+    echo "No test was found. It is possible you configured without --with-gtest or you run it from wrong directory" >&2
     exit 1
     exit 1
 fi
 fi

+ 7 - 0
tools/valgrind_test_cleaner.pl

@@ -14,6 +14,13 @@ use warnings;
 #
 #
 # Of course, the rest still can contain many uninteresting entries.
 # Of course, the rest still can contain many uninteresting entries.
 
 
+# Yes, it's perl even when we use python. I wrote it for myself when
+# I needed to clean the outputs and after it proved useful to me, I
+# thought it might be for others too, so I just included it. It's not
+# that we would be switching to perl. If it should grow in future to
+# include more heuristics and do something more fancy, we should probably
+# rewrite it in python instead.
+
 my ($block, $blockOK);
 my ($block, $blockOK);
 
 
 sub endBlock(_) {
 sub endBlock(_) {