Browse Source

Add syslog handler unittest


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac176@2337 e5f2f494-b856-4b98-b285-d166d9295462
Jerry 15 years ago
parent
commit
bfc4bec539
2 changed files with 14 additions and 2 deletions
  1. 2 2
      src/lib/python/isc/log/log.py
  2. 12 0
      src/lib/python/isc/log/tests/log_test.py

+ 2 - 2
src/lib/python/isc/log/log.py

@@ -177,13 +177,13 @@ class NSLogger(logging.getLoggerClass()):
         self._stream_handler.setFormatter(TIME_FORMATTER)
         self.addHandler(self._stream_handler)
 
-    def _add_syslog_handler(self, facility=syslog.LOG_USER):
+    def _add_syslog_handler(self, nsfacility=syslog.LOG_USER):
         """Add a syslog handler.
    
         If facility is not specified, LOG_USER is used.
         The default severity level is INFO.
         """
-        self._syslog_handler = NSSysLogHandler('BIND10', facility)
+        self._syslog_handler = NSSysLogHandler('BIND10', facility = nsfacility)
         self._syslog_handler.setFormatter(FORMATTER)
         #set syslog handler severity level INFO
         self._syslog_handler.setLevel(logging.INFO)

+ 12 - 0
src/lib/python/isc/log/tests/log_test.py

@@ -50,6 +50,18 @@ class TestRotateFileHandler(unittest.TestCase):
         self.FILE_LOG2.close()
         self.FILE_LOG3.close()
 
+class TestSysLogHandler(unittest.TestCase):
+    def setUp(self):
+        self.handler = NSSysLogHandler("BIND10")
+
+    def test_encodeLevel(self):
+        sysLevel = self.handler._encodeLevel(logging.ERROR)
+        self.assertEqual(sysLevel, syslog.LOG_ERR)
+
+    def test_emit(self):
+        record = logging.LogRecord(None, None, "", 0, "syslog handler", (), None, None)
+        self.handler.emit(record)
+
 
 class TestLogging(unittest.TestCase):