Parcourir la source

[2211] removed an extra block from sendCommand() with clarification comments

JINMEI Tatuya il y a 12 ans
Parent
commit
d709ef90b8
1 fichiers modifiés avec 6 ajouts et 5 suppressions
  1. 6 5
      src/bin/auth/datasrc_clients_mgr.h

+ 6 - 5
src/bin/auth/datasrc_clients_mgr.h

@@ -242,11 +242,12 @@ private:
     void sendCommand(datasrc_clientmgr_internal::CommandID command,
                      data::ConstElementPtr arg)
     {
-        {
-            typename MutexType::Locker locker(queue_mutex_);
-            command_queue_.push_back(
-                datasrc_clientmgr_internal::Command(command, arg));
-        }
+        // The lock will be held until the end of this method.  Only
+        // push_back has to be protected, but we can avoid having an extra
+        // block this way.
+        typename MutexType::Locker locker(queue_mutex_);
+        command_queue_.push_back(
+            datasrc_clientmgr_internal::Command(command, arg));
         cond_.signal();
     }