Browse Source

added some more pathological cases to badText.
actually I'm not sure if these should be rejected or accepted.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1027 e5f2f494-b856-4b98-b285-d166d9295462

JINMEI Tatuya 15 years ago
parent
commit
e587cfd186
1 changed files with 7 additions and 0 deletions
  1. 7 0
      src/lib/dns/cpp/tests/rdata_dnskey_unittest.cc

+ 7 - 0
src/lib/dns/cpp/tests/rdata_dnskey_unittest.cc

@@ -73,6 +73,13 @@ TEST_F(Rdata_DNSKEY_Test, badText)
                  InvalidRdataText);
                  InvalidRdataText);
     EXPECT_THROW(generic::DNSKEY("257 3 5 BAAAAAAAAAAAD"),
     EXPECT_THROW(generic::DNSKEY("257 3 5 BAAAAAAAAAAAD"),
                  BadBase64String);
                  BadBase64String);
+    // Should this be allowed?
+//     EXPECT_THROW(generic::DNSKEY("257 3 5BEAAEFTd"),
+//                  InvalidRdataText);
+    // How about this?  It's even more confusing for the parser because
+    // it could be ambiguous '51 EAAA' vs '5 1EAA..'
+//     EXPECT_THROW(generic::DNSKEY("257 3 51EAAEFTd"),
+//                  InvalidRdataText);
 }
 }
 
 
 TEST_F(Rdata_DNSKEY_Test, toWireRenderer)
 TEST_F(Rdata_DNSKEY_Test, toWireRenderer)