Browse Source

[master] Moved loadLibrarie() at the end

Francis Dupont 8 years ago
parent
commit
ec32546ecb
2 changed files with 10 additions and 10 deletions
  1. 5 5
      src/bin/dhcp4/json_config_parser.cc
  2. 5 5
      src/bin/dhcp6/json_config_parser.cc

+ 5 - 5
src/bin/dhcp4/json_config_parser.cc

@@ -628,15 +628,15 @@ configureDhcp4Server(Dhcpv4Srv&, isc::data::ConstElementPtr config_set,
             // No need to commit interface names as this is handled by the
             // No need to commit interface names as this is handled by the
             // CfgMgr::commit() function.
             // CfgMgr::commit() function.
 
 
-            // This occurs last as if it succeeds, there is no easy way
-            // revert it.  As a result, the failure to commit a subsequent
-            // change causes problems when trying to roll back.
-            hooks_parser.loadLibraries();
-
             // Apply the staged D2ClientConfig, used to be done by parser commit
             // Apply the staged D2ClientConfig, used to be done by parser commit
             D2ClientConfigPtr cfg;
             D2ClientConfigPtr cfg;
             cfg = CfgMgr::instance().getStagingCfg()->getD2ClientConfig();
             cfg = CfgMgr::instance().getStagingCfg()->getD2ClientConfig();
             CfgMgr::instance().setD2ClientConfig(cfg);
             CfgMgr::instance().setD2ClientConfig(cfg);
+
+            // This occurs last as if it succeeds, there is no easy way
+            // revert it.  As a result, the failure to commit a subsequent
+            // change causes problems when trying to roll back.
+            hooks_parser.loadLibraries();
         }
         }
         catch (const isc::Exception& ex) {
         catch (const isc::Exception& ex) {
             LOG_ERROR(dhcp4_logger, DHCP4_PARSER_COMMIT_FAIL).arg(ex.what());
             LOG_ERROR(dhcp4_logger, DHCP4_PARSER_COMMIT_FAIL).arg(ex.what());

+ 5 - 5
src/bin/dhcp6/json_config_parser.cc

@@ -851,15 +851,15 @@ configureDhcp6Server(Dhcpv6Srv&, isc::data::ConstElementPtr config_set,
             // No need to commit interface names as this is handled by the
             // No need to commit interface names as this is handled by the
             // CfgMgr::commit() function.
             // CfgMgr::commit() function.
 
 
-            // This occurs last as if it succeeds, there is no easy way to
-            // revert it.  As a result, the failure to commit a subsequent
-            // change causes problems when trying to roll back.
-            hooks_parser.loadLibraries();
-
             // Apply staged D2ClientConfig, used to be done by parser commit
             // Apply staged D2ClientConfig, used to be done by parser commit
             D2ClientConfigPtr cfg;
             D2ClientConfigPtr cfg;
             cfg = CfgMgr::instance().getStagingCfg()->getD2ClientConfig();
             cfg = CfgMgr::instance().getStagingCfg()->getD2ClientConfig();
             CfgMgr::instance().setD2ClientConfig(cfg);
             CfgMgr::instance().setD2ClientConfig(cfg);
+
+            // This occurs last as if it succeeds, there is no easy way to
+            // revert it.  As a result, the failure to commit a subsequent
+            // change causes problems when trying to roll back.
+            hooks_parser.loadLibraries();
         }
         }
         catch (const isc::Exception& ex) {
         catch (const isc::Exception& ex) {
             LOG_ERROR(dhcp6_logger, DHCP6_PARSER_COMMIT_FAIL).arg(ex.what());
             LOG_ERROR(dhcp6_logger, DHCP6_PARSER_COMMIT_FAIL).arg(ex.what());