Browse Source

use the DISABLED prefix for a failed test (instead of 'if 0'ing it)

trivial change, skipping review.  build/test okay.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1798 e5f2f494-b856-4b98-b285-d166d9295462
JINMEI Tatuya 15 years ago
parent
commit
f791a5a057
1 changed files with 4 additions and 2 deletions
  1. 4 2
      src/lib/dns/tests/rdata_ds_unittest.cc

+ 4 - 2
src/lib/dns/tests/rdata_ds_unittest.cc

@@ -52,13 +52,15 @@ TEST_F(Rdata_DS_Test, badText_DS) {
     EXPECT_THROW(const generic::DS ds2("11111 5 22222 BEEF"), InvalidRdataText);
     EXPECT_THROW(const generic::DS ds2("11111 5 22222 BEEF"), InvalidRdataText);
     EXPECT_THROW(const generic::DS ds2("11111 5 2"), InvalidRdataText);
     EXPECT_THROW(const generic::DS ds2("11111 5 2"), InvalidRdataText);
     EXPECT_THROW(const generic::DS ds2("GARBAGE IN"), InvalidRdataText);
     EXPECT_THROW(const generic::DS ds2("GARBAGE IN"), InvalidRdataText);
+}
 
 
-#if 0              // this test currently fails
+// this test currently fails; we must fix it, and then migrate the test to
+// badText_DS
+TEST_F(Rdata_DS_Test, DISABLED_badText_DS) {
     // no space between the digest type and the digest.
     // no space between the digest type and the digest.
     EXPECT_THROW(const generic::DS ds2(
     EXPECT_THROW(const generic::DS ds2(
                      "12892 5 2F1E184C0E1D615D20EB3C223ACED3B03C773DD952D"
                      "12892 5 2F1E184C0E1D615D20EB3C223ACED3B03C773DD952D"
                      "5F0EB5C777586DE18DA6B5"), InvalidRdataText);
                      "5F0EB5C777586DE18DA6B5"), InvalidRdataText);
-#endif
 }
 }
 
 
 TEST_F(Rdata_DS_Test, createFromWire_DS) {
 TEST_F(Rdata_DS_Test, createFromWire_DS) {