Browse Source

[2404] Minor changes as a result of review

Stephen Morris 12 years ago
parent
commit
fca3132940
2 changed files with 6 additions and 1 deletions
  1. 5 0
      src/lib/dhcp/duid.h
  2. 1 1
      src/lib/dhcpsrv/mysql_lease_mgr.h

+ 5 - 0
src/lib/dhcp/duid.h

@@ -91,6 +91,11 @@ public:
     /// @brief Maximum size of a client ID
     ///
     /// This is the same as the maximum size of the underlying DUID.
+    ///
+    /// @note RFC 2131 does not specify an upper length of a client ID, the
+    ///       value chosen here just being that of the underlying DUID.  For
+    ///       some backend database, there may be a possible (minor)
+    ///       performance enhancement if this were smaller.
     static const size_t MAX_CLIENT_ID_LEN = DUID::MAX_DUID_LEN;
 
     /// @brief Constructor based on vector<uint8_t>

+ 1 - 1
src/lib/dhcpsrv/mysql_lease_mgr.h

@@ -110,7 +110,7 @@ public:
     /// @brief Returns an IPv4 lease for specified IPv4 address
     ///
     /// This method return a lease that is associated with a given address.
-    /// For other query types (by hardware addr, by DUID) there can be
+    /// For other query types (by hardware addr, by Client ID) there can be
     /// several leases in different subnets (e.g. for mobile clients that
     /// got address in different subnets). However, for a single address
     /// there can be only one lease, so this method returns a pointer to