Browse Source

[2480] avoid redundant text dump of RRSIGs in pullSigs().

now that RRset::toText() includes RRSIGs, the additional toText() is not
necessary; in fact, that would lead to confusing output from failed tests.
JINMEI Tatuya 12 years ago
parent
commit
fe40dade09
1 changed files with 1 additions and 2 deletions
  1. 1 2
      src/lib/testutils/dnsmessage_test.h

+ 1 - 2
src/lib/testutils/dnsmessage_test.h

@@ -208,10 +208,9 @@ pullSigs(std::vector<isc::dns::ConstRRsetPtr>& rrsets,
 {
     for (ITERATOR it = begin; it != end; ++it) {
         rrsets.push_back(*it);
-        text += (*it)->toText();
+        text += (*it)->toText(); // this will include RRSIG, if attached.
         if ((*it)->getRRsig()) {
             rrsets.push_back((*it)->getRRsig());
-            text += (*it)->getRRsig()->toText();
         }
     }
 }