123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955 |
- // Copyright (C) 2012 Internet Systems Consortium, Inc. ("ISC")
- //
- // Permission to use, copy, modify, and/or distribute this software for any
- // purpose with or without fee is hereby granted, provided that the above
- // copyright notice and this permission notice appear in all copies.
- //
- // THE SOFTWARE IS PROVIDED "AS IS" AND ISC DISCLAIMS ALL WARRANTIES WITH
- // REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
- // AND FITNESS. IN NO EVENT SHALL ISC BE LIABLE FOR ANY SPECIAL, DIRECT,
- // INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
- // LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE
- // OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
- // PERFORMANCE OF THIS SOFTWARE.
- #include <dns/master_loader_callbacks.h>
- #include <dns/master_loader.h>
- #include <dns/rrtype.h>
- #include <dns/rrset.h>
- #include <dns/rrclass.h>
- #include <dns/rrttl.h>
- #include <dns/name.h>
- #include <dns/rdata.h>
- #include <gtest/gtest.h>
- #include <boost/bind.hpp>
- #include <boost/lexical_cast.hpp>
- #include <boost/scoped_ptr.hpp>
- #include <string>
- #include <vector>
- #include <list>
- #include <sstream>
- using namespace isc::dns;
- using std::vector;
- using std::string;
- using std::list;
- using std::stringstream;
- using std::endl;
- using boost::lexical_cast;
- namespace {
- class MasterLoaderTest : public ::testing::Test {
- public:
- MasterLoaderTest() :
- callbacks_(boost::bind(&MasterLoaderTest::callback, this,
- &errors_, _1, _2, _3),
- boost::bind(&MasterLoaderTest::callback, this,
- &warnings_, _1, _2, _3))
- {}
- void TearDown() {
- // Check there are no more RRs we didn't expect
- EXPECT_TRUE(rrsets_.empty());
- }
- /// Concatenate file, line, and reason, and add it to either errors
- /// or warnings
- void callback(vector<string>* target, const std::string& file, size_t line,
- const std::string& reason)
- {
- std::stringstream ss;
- ss << reason << " [" << file << ":" << line << "]";
- target->push_back(ss.str());
- }
- void addRRset(const Name& name, const RRClass& rrclass,
- const RRType& rrtype, const RRTTL& rrttl,
- const rdata::RdataPtr& data) {
- const RRsetPtr rrset(new BasicRRset(name, rrclass, rrtype, rrttl));
- rrset->addRdata(data);
- rrsets_.push_back(rrset);
- }
- void setLoader(const char* file, const Name& origin,
- const RRClass& rrclass, const MasterLoader::Options options)
- {
- loader_.reset(new MasterLoader(file, origin, rrclass, callbacks_,
- boost::bind(&MasterLoaderTest::addRRset,
- this, _1, _2, _3, _4, _5),
- options));
- }
- void setLoader(std::istream& stream, const Name& origin,
- const RRClass& rrclass, const MasterLoader::Options options)
- {
- loader_.reset(new MasterLoader(stream, origin, rrclass, callbacks_,
- boost::bind(&MasterLoaderTest::addRRset,
- this, _1, _2, _3, _4, _5),
- options));
- }
- static string prepareZone(const string& line, bool include_last) {
- string result;
- result += "example.org. 3600 IN SOA ns1.example.org. "
- "admin.example.org. 1234 3600 1800 2419200 7200\n";
- result += line;
- if (include_last) {
- result += "\n";
- result += "correct 3600 IN A 192.0.2.2\n";
- }
- return (result);
- }
- void clear() {
- warnings_.clear();
- errors_.clear();
- rrsets_.clear();
- }
- // Check the next RR in the ones produced by the loader
- // Other than passed arguments are checked to be the default for the tests
- void checkRR(const string& name, const RRType& type, const string& data,
- const RRTTL& rrttl = RRTTL(3600)) {
- ASSERT_FALSE(rrsets_.empty());
- RRsetPtr current = rrsets_.front();
- rrsets_.pop_front();
- EXPECT_EQ(Name(name), current->getName());
- EXPECT_EQ(type, current->getType());
- EXPECT_EQ(RRClass::IN(), current->getClass());
- EXPECT_EQ(rrttl, current->getTTL());
- ASSERT_EQ(1, current->getRdataCount());
- EXPECT_EQ(0, isc::dns::rdata::createRdata(type, RRClass::IN(), data)->
- compare(current->getRdataIterator()->getCurrent()));
- }
- void checkBasicRRs() {
- checkRR("example.org", RRType::SOA(),
- "ns1.example.org. admin.example.org. "
- "1234 3600 1800 2419200 7200");
- checkRR("example.org", RRType::NS(), "ns1.example.org.");
- checkRR("www.example.org", RRType::A(), "192.0.2.1");
- checkRR("www.example.org", RRType::AAAA(), "2001:db8::1");
- }
- void checkARR(const string& name) {
- checkRR(name, RRType::A(), "192.0.2.1");
- }
- MasterLoaderCallbacks callbacks_;
- boost::scoped_ptr<MasterLoader> loader_;
- vector<string> errors_;
- vector<string> warnings_;
- list<RRsetPtr> rrsets_;
- };
- // Test simple loading. The zone file contains no tricky things, and nothing is
- // omitted. No RRset contains more than one RR Also no errors or warnings.
- TEST_F(MasterLoaderTest, basicLoad) {
- setLoader(TEST_DATA_SRCDIR "/example.org", Name("example.org."),
- RRClass::IN(), MasterLoader::MANY_ERRORS);
- EXPECT_FALSE(loader_->loadedSucessfully());
- // The following three should be set to 0 initially in case the loader
- // is constructed from a file name.
- EXPECT_EQ(0, loader_->getSize());
- EXPECT_EQ(0, loader_->getPosition());
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- EXPECT_TRUE(warnings_.empty());
- // Hardcode expected values taken from the test data file, assuming it
- // won't change too often.
- EXPECT_EQ(549, loader_->getSize());
- EXPECT_EQ(549, loader_->getPosition());
- checkBasicRRs();
- }
- // Test the $INCLUDE directive
- TEST_F(MasterLoaderTest, include) {
- // Test various cases of include
- const char* includes[] = {
- "$include",
- "$INCLUDE",
- "$Include",
- "$InCluDe",
- "\"$INCLUDE\"",
- NULL
- };
- for (const char** include = includes; *include != NULL; ++include) {
- SCOPED_TRACE(*include);
- clear();
- // Prepare input source that has the include and some more data
- // below (to see it returns back to the original source).
- const string include_str = string(*include) + " " +
- TEST_DATA_SRCDIR + "/example.org\nwww 3600 IN AAAA 2001:db8::1\n";
- stringstream ss(include_str);
- setLoader(ss, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- EXPECT_TRUE(warnings_.empty());
- checkBasicRRs();
- checkRR("www.example.org", RRType::AAAA(), "2001:db8::1");
- }
- }
- TEST_F(MasterLoaderTest, includeAndIncremental) {
- // Check getSize() and getPosition() are adjusted before and after
- // $INCLUDE.
- const string first_rr = "before.example.org. 0 A 192.0.2.1\n";
- const string include_str = "$INCLUDE " TEST_DATA_SRCDIR "/example.org";
- const string zone_data = first_rr + include_str + "\n" +
- "www 3600 IN AAAA 2001:db8::1\n";
- stringstream ss(zone_data);
- setLoader(ss, Name("example.org."), RRClass::IN(), MasterLoader::DEFAULT);
- // On construction, getSize() returns the size of the data (exclude the
- // the file to be included); position is set to 0.
- EXPECT_EQ(zone_data.size(), loader_->getSize());
- EXPECT_EQ(0, loader_->getPosition());
- // Read the first RR. getSize() doesn't change; position should be
- // at the end of the first line.
- loader_->loadIncremental(1);
- EXPECT_EQ(zone_data.size(), loader_->getSize());
- EXPECT_EQ(first_rr.size(), loader_->getPosition());
- // Read next 4. It includes $INCLUDE processing. Magic number of 549
- // is the size of the test zone file (see above); 506 is the position in
- // the file at the end of 4th RR (due to extra comments it's smaller than
- // the file size).
- loader_->loadIncremental(4);
- EXPECT_EQ(zone_data.size() + 549, loader_->getSize());
- EXPECT_EQ(first_rr.size() + include_str.size() + 506,
- loader_->getPosition());
- // Read the last one. At this point getSize and getPosition return
- // the same value, indicating progress of 100%.
- loader_->loadIncremental(1);
- EXPECT_EQ(zone_data.size() + 549, loader_->getSize());
- EXPECT_EQ(zone_data.size() + 549, loader_->getPosition());
- // we were not interested in checking RRs in this test. clear them to
- // not confuse TearDown().
- rrsets_.clear();
- }
- // A commonly used helper to check callback message.
- void
- checkCallbackMessage(const string& actual_msg, const string& expected_msg,
- size_t expected_line) {
- // The actual message should begin with the expected message.
- EXPECT_EQ(0, actual_msg.find(expected_msg)) << "actual message: " <<
- actual_msg << " expected: " <<
- expected_msg;
- // and it should end with "...:<line_num>]"
- const string line_desc = ":" + lexical_cast<string>(expected_line) + "]";
- EXPECT_EQ(actual_msg.size() - line_desc.size(),
- actual_msg.find(line_desc)) << "Expected on line " <<
- expected_line;
- }
- TEST_F(MasterLoaderTest, origin) {
- // Various forms of the directive
- const char* origins[] = {
- "$origin",
- "$ORIGIN",
- "$Origin",
- "$OrigiN",
- "\"$ORIGIN\"",
- NULL
- };
- for (const char** origin = origins; *origin != NULL; ++origin) {
- SCOPED_TRACE(*origin);
- clear();
- const string directive = *origin;
- const string input =
- "@ 1H IN A 192.0.2.1\n" +
- directive + " sub.example.org.\n"
- "\"www\" 1H IN A 192.0.2.1\n" +
- // Relative name in the origin
- directive + " relative\n"
- "@ 1H IN A 192.0.2.1\n"
- // Origin is _not_ used here (absolute name)
- "noorigin.example.org. 60M IN A 192.0.2.1\n";
- stringstream ss(input);
- setLoader(ss, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- // There's a relative origin in it, we warn about that.
- EXPECT_EQ(1, warnings_.size());
- checkCallbackMessage(warnings_.at(0),
- "The new origin is relative, did you really mean "
- "relative.sub.example.org.?", 4);
- checkARR("example.org");
- checkARR("www.sub.example.org");
- checkARR("relative.sub.example.org");
- checkARR("noorigin.example.org");
- }
- }
- // Test the source is correctly popped even after error
- TEST_F(MasterLoaderTest, popAfterError) {
- const string include_str = "$include " TEST_DATA_SRCDIR
- "/broken.zone\nwww 3600 IN AAAA 2001:db8::1\n";
- stringstream ss(include_str);
- // We perform the test with MANY_ERRORS, we want to see what happens
- // after the error.
- setLoader(ss, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- loader_->load();
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_EQ(1, errors_.size()); // For the broken RR
- EXPECT_EQ(1, warnings_.size()); // For missing EOLN
- // The included file doesn't contain anything usable, but the
- // line after the include should be there.
- checkRR("www.example.org", RRType::AAAA(), "2001:db8::1");
- }
- // Check it works the same when created based on a stream, not filename
- TEST_F(MasterLoaderTest, streamConstructor) {
- const string zone_data(prepareZone("", true));
- stringstream zone_stream(zone_data);
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- EXPECT_FALSE(loader_->loadedSucessfully());
- // Unlike the basicLoad test, if we construct the loader from a stream
- // getSize() returns the data size in the stream immediately after the
- // construction.
- EXPECT_EQ(zone_data.size(), loader_->getSize());
- EXPECT_EQ(0, loader_->getPosition());
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- EXPECT_TRUE(warnings_.empty());
- checkRR("example.org", RRType::SOA(), "ns1.example.org. "
- "admin.example.org. 1234 3600 1800 2419200 7200");
- checkRR("correct.example.org", RRType::A(), "192.0.2.2");
- // On completion of the load, both getSize() and getPosition() return the
- // size of the data.
- EXPECT_EQ(zone_data.size(), loader_->getSize());
- EXPECT_EQ(zone_data.size(), loader_->getPosition());
- }
- // Try loading data incrementally.
- TEST_F(MasterLoaderTest, incrementalLoad) {
- setLoader(TEST_DATA_SRCDIR "/example.org", Name("example.org."),
- RRClass::IN(), MasterLoader::MANY_ERRORS);
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_FALSE(loader_->loadIncremental(2));
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- EXPECT_TRUE(warnings_.empty());
- checkRR("example.org", RRType::SOA(),
- "ns1.example.org. admin.example.org. "
- "1234 3600 1800 2419200 7200");
- checkRR("example.org", RRType::NS(), "ns1.example.org.");
- // The third one is not loaded yet
- EXPECT_TRUE(rrsets_.empty());
- // Load the rest.
- EXPECT_TRUE(loader_->loadIncremental(20));
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- EXPECT_TRUE(warnings_.empty());
- checkRR("www.example.org", RRType::A(), "192.0.2.1");
- checkRR("www.example.org", RRType::AAAA(), "2001:db8::1");
- }
- // Try loading from file that doesn't exist. There should be single error
- // saying so.
- TEST_F(MasterLoaderTest, invalidFile) {
- setLoader("This file doesn't exist at all",
- Name("exmaple.org."), RRClass::IN(), MasterLoader::MANY_ERRORS);
- // Nothing yet. The loader is dormant until invoked.
- // Is it really what we want?
- EXPECT_TRUE(errors_.empty());
- loader_->load();
- EXPECT_TRUE(warnings_.empty());
- EXPECT_TRUE(rrsets_.empty());
- ASSERT_EQ(1, errors_.size());
- EXPECT_EQ(0, errors_[0].find("Error opening the input source file: ")) <<
- "Different error: " << errors_[0];
- }
- struct ErrorCase {
- const char* const line; // The broken line in master file
- const char* const reason; // If non NULL, the reason string
- const char* const problem; // Description of the problem for SCOPED_TRACE
- } const error_cases[] = {
- { "www... 3600 IN A 192.0.2.1", NULL, "Invalid name" },
- { "www FORTNIGHT IN A 192.0.2.1", NULL, "Invalid TTL" },
- { "www 3600 XX A 192.0.2.1", NULL, "Invalid class" },
- { "www 3600 IN A bad_ip", NULL, "Invalid Rdata" },
- // Parameter ordering errors
- { "www IN A 3600 192.168.2.7",
- "createRdata from text failed: IN/A RDATA construction from text failed",
- "Incorrect order of class, TTL and type" },
- { "www A IN 3600 192.168.2.8",
- "createRdata from text failed: IN/A RDATA construction from text failed",
- "Incorrect order of class, TTL and type" },
- { "www 3600 A IN 192.168.2.7",
- "createRdata from text failed: IN/A RDATA construction from text failed",
- "Incorrect order of class, TTL and type" },
- { "www A 3600 IN 192.168.2.8",
- "createRdata from text failed: IN/A RDATA construction from text failed",
- "Incorrect order of class, TTL and type" },
- // Missing type and Rdata
- { "www", "unexpected end of input", "Missing type and Rdata" },
- { "www 3600", "unexpected end of input", "Missing type and Rdata" },
- { "www IN", "unexpected end of input", "Missing type and Rdata" },
- { "www 3600 IN", "unexpected end of input", "Missing type and Rdata" },
- { "www IN 3600", "unexpected end of input", "Missing type and Rdata" },
- // Missing Rdata
- { "www A",
- "createRdata from text failed: IN/A RDATA construction from text failed",
- "Missing Rdata" },
- { "www 3600 A",
- "createRdata from text failed: IN/A RDATA construction from text failed",
- "Missing Rdata" },
- { "www IN A",
- "createRdata from text failed: IN/A RDATA construction from text failed",
- "Missing Rdata" },
- { "www 3600 IN A",
- "createRdata from text failed: IN/A RDATA construction from text failed",
- "Missing Rdata" },
- { "www IN 3600 A",
- "createRdata from text failed: IN/A RDATA construction from text failed",
- "Missing Rdata" },
- { "www 3600 IN", NULL, "Unexpected EOLN" },
- { "www 3600 CH TXT nothing", "Class mismatch: CH vs. IN",
- "Class mismatch" },
- { "www \"3600\" IN A 192.0.2.1", NULL, "Quoted TTL" },
- { "www 3600 \"IN\" A 192.0.2.1", NULL, "Quoted class" },
- { "www 3600 IN \"A\" 192.0.2.1", NULL, "Quoted type" },
- { "unbalanced)paren 3600 IN A 192.0.2.1", NULL, "Token error 1" },
- { "www 3600 unbalanced)paren A 192.0.2.1", NULL,
- "Token error 2" },
- // Check the unknown directive. The rest looks like ordinary RR,
- // so we see the $ is actually special.
- { "$UNKNOWN 3600 IN A 192.0.2.1", NULL, "Unknown $ directive" },
- { "$INCLUD " TEST_DATA_SRCDIR "/example.org", "Unknown directive 'INCLUD'",
- "Include too short" },
- { "$INCLUDES " TEST_DATA_SRCDIR "/example.org",
- "Unknown directive 'INCLUDES'", "Include too long" },
- { "$INCLUDE", "unexpected end of input", "Missing include path" },
- // The following two error messages are system dependant, omitting
- { "$INCLUDE /file/not/found", NULL, "Include file not found" },
- { "$INCLUDE /file/not/found example.org. and here goes bunch of garbage",
- NULL, "Include file not found and garbage at the end of line" },
- { "$ORIGIN", "unexpected end of input", "Missing origin name" },
- { "$ORIGIN invalid...name", "duplicate period in invalid...name",
- "Invalid name for origin" },
- { "$ORIGIN )brokentoken", "unbalanced parentheses",
- "Broken token in origin" },
- { "$ORIGIN example.org. garbage", "Extra tokens at the end of line",
- "Garbage after origin" },
- { "$ORIGI name.", "Unknown directive 'ORIGI'", "$ORIGIN too short" },
- { "$ORIGINAL name.", "Unknown directive 'ORIGINAL'", "$ORIGIN too long" },
- { "$TTL 100 extra-garbage", "Extra tokens at the end of line",
- "$TTL with extra token" },
- { "$TTL", "unexpected end of input", "missing TTL" },
- { "$TTL No-ttl", "Unknown unit used: N in: No-ttl", "bad TTL" },
- { "$TTL \"100\"", "invalid TTL: \"100\"", "bad TTL, quoted" },
- { "$TT 100", "Unknown directive 'TT'", "bad directive, too short" },
- { "$TTLLIKE 100", "Unknown directive 'TTLLIKE'", "bad directive, extra" },
- { NULL, NULL, NULL }
- };
- // Test a broken zone is handled properly. We test several problems,
- // both in strict and lenient mode.
- TEST_F(MasterLoaderTest, brokenZone) {
- for (const ErrorCase* ec = error_cases; ec->line != NULL; ++ec) {
- SCOPED_TRACE(ec->problem);
- const string zone(prepareZone(ec->line, true));
- {
- SCOPED_TRACE("Strict mode");
- clear();
- stringstream zone_stream(zone);
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::DEFAULT);
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_THROW(loader_->load(), MasterLoaderError);
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_EQ(1, errors_.size());
- if (ec->reason != NULL) {
- checkCallbackMessage(errors_.at(0), ec->reason, 2);
- }
- EXPECT_TRUE(warnings_.empty());
- checkRR("example.org", RRType::SOA(), "ns1.example.org. "
- "admin.example.org. 1234 3600 1800 2419200 7200");
- // In the strict mode, it is aborted. The last RR is not
- // even attempted.
- EXPECT_TRUE(rrsets_.empty());
- }
- {
- SCOPED_TRACE("Lenient mode");
- clear();
- stringstream zone_stream(zone);
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_NO_THROW(loader_->load());
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_EQ(1, errors_.size());
- EXPECT_TRUE(warnings_.empty());
- checkRR("example.org", RRType::SOA(), "ns1.example.org. "
- "admin.example.org. 1234 3600 1800 2419200 7200");
- // This one is below the error one.
- checkRR("correct.example.org", RRType::A(), "192.0.2.2");
- EXPECT_TRUE(rrsets_.empty());
- }
- {
- SCOPED_TRACE("Error at EOF");
- // This case is interesting only in the lenient mode.
- clear();
- const string zoneEOF(prepareZone(ec->line, false));
- stringstream zone_stream(zoneEOF);
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_NO_THROW(loader_->load());
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_EQ(1, errors_.size()) << errors_[0] << "\n" << errors_[1];
- // The unexpected EOF warning
- EXPECT_EQ(1, warnings_.size());
- checkRR("example.org", RRType::SOA(), "ns1.example.org. "
- "admin.example.org. 1234 3600 1800 2419200 7200");
- EXPECT_TRUE(rrsets_.empty());
- }
- }
- }
- // Check that a garbage after the include generates an error, but not fatal
- // one (in lenient mode) and we can recover.
- TEST_F(MasterLoaderTest, includeWithGarbage) {
- // Include an origin (example.org) because we expect it to be handled
- // soon and we don't want it to break here.
- const string include_str("$INCLUDE " TEST_DATA_SRCDIR
- "/example.org example.org. bunch of other stuff\n"
- "www 3600 IN AAAA 2001:db8::1\n");
- stringstream zone_stream(include_str);
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- EXPECT_NO_THROW(loader_->load());
- EXPECT_FALSE(loader_->loadedSucessfully());
- ASSERT_EQ(1, errors_.size());
- checkCallbackMessage(errors_.at(0), "Extra tokens at the end of line", 1);
- // It says something about extra tokens at the end
- EXPECT_NE(string::npos, errors_[0].find("Extra"));
- EXPECT_TRUE(warnings_.empty());
- checkBasicRRs();
- checkRR("www.example.org", RRType::AAAA(), "2001:db8::1");
- }
- // Check we error about garbage at the end of $ORIGIN line (but the line
- // works).
- TEST_F(MasterLoaderTest, originWithGarbage) {
- const string origin_str = "$ORIGIN www.example.org. More garbage here\n"
- "@ 1H IN A 192.0.2.1\n";
- stringstream ss(origin_str);
- setLoader(ss, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- EXPECT_NO_THROW(loader_->load());
- EXPECT_FALSE(loader_->loadedSucessfully());
- ASSERT_EQ(1, errors_.size());
- checkCallbackMessage(errors_.at(0), "Extra tokens at the end of line", 1);
- EXPECT_TRUE(warnings_.empty());
- checkARR("www.example.org");
- }
- // Test we can pass both file to include and the origin to switch
- TEST_F(MasterLoaderTest, includeAndOrigin) {
- // First, switch origin to something else, so we can check it is
- // switched back.
- const string include_string = "$ORIGIN www.example.org.\n"
- "@ 1H IN A 192.0.2.1\n"
- // Then include the file with data and switch origin back
- "$INCLUDE " TEST_DATA_SRCDIR "/example.org example.org.\n"
- // Another RR to see we fall back to the previous origin.
- "www 1H IN A 192.0.2.1\n";
- stringstream ss(include_string);
- setLoader(ss, Name("example.org"), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- // Successfully load the data
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- EXPECT_TRUE(warnings_.empty());
- // And check it's the correct data
- checkARR("www.example.org");
- checkBasicRRs();
- checkARR("www.www.example.org");
- }
- // Like above, but the origin after include is bogus. The whole line should
- // be rejected.
- TEST_F(MasterLoaderTest, includeAndBadOrigin) {
- const string include_string =
- "$INCLUDE " TEST_DATA_SRCDIR "/example.org example..org.\n"
- // Another RR to see the switch survives after we exit include
- "www 1H IN A 192.0.2.1\n";
- stringstream ss(include_string);
- setLoader(ss, Name("example.org"), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- loader_->load();
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_EQ(1, errors_.size());
- checkCallbackMessage(errors_.at(0), "duplicate period in example..org.",
- 1);
- EXPECT_TRUE(warnings_.empty());
- // And check it's the correct data
- checkARR("www.example.org");
- }
- // Check the origin doesn't get outside of the included file.
- TEST_F(MasterLoaderTest, includeOriginRestore) {
- const string include_string =
- "$INCLUDE " TEST_DATA_SRCDIR "/origincheck.txt\n"
- "@ 1H IN A 192.0.2.1\n";
- stringstream ss(include_string);
- setLoader(ss, Name("example.org"), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- // Successfully load the data
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- EXPECT_TRUE(warnings_.empty());
- // And check it's the correct data
- checkARR("www.example.org");
- checkARR("example.org");
- }
- // Check we restore the last name for initial whitespace when returning from
- // include. But we do produce a warning if there's one just ofter the include.
- TEST_F(MasterLoaderTest, includeAndInitialWS) {
- const string include_string = "xyz 1H IN A 192.0.2.1\n"
- "$INCLUDE " TEST_DATA_SRCDIR "/example.org\n"
- " 1H IN A 192.0.2.1\n";
- stringstream ss(include_string);
- setLoader(ss, Name("example.org"), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- // Successfully load the data
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- EXPECT_EQ(1, warnings_.size());
- checkCallbackMessage(warnings_.at(0),
- "Owner name omitted around $INCLUDE, the result might "
- "not be as expected", 3);
- checkARR("xyz.example.org");
- checkBasicRRs();
- checkARR("xyz.example.org");
- }
- // Test for "$TTL"
- TEST_F(MasterLoaderTest, ttlDirective) {
- stringstream zone_stream;
- // Set the default TTL with $TTL followed by an RR omitting the TTL
- zone_stream << "$TTL 1800\nexample.org. IN A 192.0.2.1\n";
- // $TTL can be quoted. Also testing the case of $TTL being changed.
- zone_stream << "\"$TTL\" 100\na.example.org. IN A 192.0.2.2\n";
- // Extended TTL form is accepted.
- zone_stream << "$TTL 1H\nb.example.org. IN A 192.0.2.3\n";
- // Matching is case insensitive.
- zone_stream << "$tTl 360\nc.example.org. IN A 192.0.2.4\n";
- // Maximum allowable TTL
- zone_stream << "$TTL 2147483647\nd.example.org. IN A 192.0.2.5\n";
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::DEFAULT);
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- checkRR("example.org", RRType::A(), "192.0.2.1", RRTTL(1800));
- checkRR("a.example.org", RRType::A(), "192.0.2.2", RRTTL(100));
- checkRR("b.example.org", RRType::A(), "192.0.2.3", RRTTL(3600));
- checkRR("c.example.org", RRType::A(), "192.0.2.4", RRTTL(360));
- checkRR("d.example.org", RRType::A(), "192.0.2.5", RRTTL(2147483647));
- }
- TEST_F(MasterLoaderTest, ttlFromSOA) {
- // No $TTL, and the SOA doesn't have an explicit TTL field. Its minimum
- // TTL field will be used as the RR's TTL, and it'll be used as the
- // default TTL for others.
- stringstream zone_stream("example.org. IN SOA . . 0 0 0 0 1800\n"
- "a.example.org. IN A 192.0.2.1\n");
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::DEFAULT);
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- checkRR("example.org", RRType::SOA(), ". . 0 0 0 0 1800", RRTTL(1800));
- checkRR("a.example.org", RRType::A(), "192.0.2.1", RRTTL(1800));
- // The use of SOA minimum TTL should have caused a warning.
- EXPECT_EQ(1, warnings_.size());
- checkCallbackMessage(warnings_.at(0),
- "no TTL specified; using SOA MINTTL instead", 1);
- }
- TEST_F(MasterLoaderTest, ttlFromPrevious) {
- // No available default TTL. 2nd and 3rd RR will use the TTL of the
- // 1st RR. This will result in a warning, but only for the first time.
- stringstream zone_stream("a.example.org. 1800 IN A 192.0.2.1\n"
- "b.example.org. IN A 192.0.2.2\n"
- "c.example.org. IN A 192.0.2.3\n");
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::DEFAULT);
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- checkRR("a.example.org", RRType::A(), "192.0.2.1", RRTTL(1800));
- checkRR("b.example.org", RRType::A(), "192.0.2.2", RRTTL(1800));
- checkRR("c.example.org", RRType::A(), "192.0.2.3", RRTTL(1800));
- EXPECT_EQ(1, warnings_.size());
- checkCallbackMessage(warnings_.at(0), "using RFC1035 TTL semantics", 2);
- }
- TEST_F(MasterLoaderTest, RRParamsOrdering) {
- // We test the order and existence of TTL, class and type. See
- // MasterLoader::MasterLoaderImpl::parseRRParams() for ordering.
- stringstream zone_stream;
- // <TTL> <class> <type> <RDATA>
- zone_stream << "a.example.org. 1800 IN A 192.0.2.1\n";
- // <type> <RDATA>
- zone_stream << "b.example.org. A 192.0.2.2\n";
- // <class> <TTL> <type> <RDATA>
- zone_stream << "c.example.org. IN 3600 A 192.0.2.3\n";
- // <TTL> <type> <RDATA>
- zone_stream << "d.example.org. 7200 A 192.0.2.4\n";
- // <class> <type> <RDATA>
- zone_stream << "e.example.org. IN A 192.0.2.5\n";
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::DEFAULT);
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- checkRR("a.example.org", RRType::A(), "192.0.2.1", RRTTL(1800));
- checkRR("b.example.org", RRType::A(), "192.0.2.2", RRTTL(1800));
- checkRR("c.example.org", RRType::A(), "192.0.2.3", RRTTL(3600));
- checkRR("d.example.org", RRType::A(), "192.0.2.4", RRTTL(7200));
- checkRR("e.example.org", RRType::A(), "192.0.2.5", RRTTL(7200));
- EXPECT_EQ(1, warnings_.size());
- checkCallbackMessage(warnings_.at(0), "using RFC1035 TTL semantics", 2);
- }
- TEST_F(MasterLoaderTest, ttlFromPreviousSOA) {
- // Mixture of the previous two cases: SOA has explicit TTL, followed by
- // an RR without an explicit TTL. In this case the minimum TTL won't be
- // recognized as the "default TTL".
- stringstream zone_stream("example.org. 100 IN SOA . . 0 0 0 0 1800\n"
- "a.example.org. IN A 192.0.2.1\n");
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::DEFAULT);
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- checkRR("example.org", RRType::SOA(), ". . 0 0 0 0 1800", RRTTL(100));
- checkRR("a.example.org", RRType::A(), "192.0.2.1", RRTTL(100));
- EXPECT_EQ(1, warnings_.size());
- checkCallbackMessage(warnings_.at(0), "using RFC1035 TTL semantics", 2);
- }
- TEST_F(MasterLoaderTest, ttlUnknown) {
- // No available TTL is known for the first RR.
- stringstream zone_stream("a.example.org. IN A 192.0.2.1\n");
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::DEFAULT);
- EXPECT_THROW(loader_->load(), MasterLoaderError);
- }
- TEST_F(MasterLoaderTest, ttlUnknownAndContinue) {
- stringstream zone_stream("a.example.org. IN A 192.0.2.1\n"
- "b.example.org. 1800 IN A 192.0.2.2\n");
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- loader_->load();
- EXPECT_FALSE(loader_->loadedSucessfully());
- checkRR("b.example.org", RRType::A(), "192.0.2.2", RRTTL(1800));
- EXPECT_TRUE(warnings_.empty());
- EXPECT_EQ(1, errors_.size());
- checkCallbackMessage(errors_.at(0), "no TTL specified; load rejected", 1);
- }
- TEST_F(MasterLoaderTest, ttlUnknownAndEOF) {
- // Similar to the previous case, but the input will be abruptly terminated
- // after the offending RR. This will cause an additional warning.
- stringstream zone_stream("a.example.org. IN A 192.0.2.1");
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- loader_->load();
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_TRUE(rrsets_.empty());
- EXPECT_EQ(1, errors_.size());
- checkCallbackMessage(errors_.at(0), "no TTL specified; load rejected", 1);
- // RDATA implementation can complain about it, too. To be independent of
- // its details, we focus on the very last warning.
- EXPECT_FALSE(warnings_.empty());
- checkCallbackMessage(*warnings_.rbegin(), "File does not end with newline",
- 1);
- }
- TEST_F(MasterLoaderTest, ttlOverflow) {
- stringstream zone_stream;
- zone_stream << "example.org. IN SOA . . 0 0 0 0 2147483648\n";
- zone_stream << "$TTL 3600\n"; // reset to an in-range value
- zone_stream << "$TTL 2147483649\n" << "a.example.org. IN A 192.0.2.1\n";
- zone_stream << "$TTL 3600\n"; // reset to an in-range value
- zone_stream << "b.example.org. 2147483650 IN A 192.0.2.2\n";
- setLoader(zone_stream, Name("example.org."), RRClass::IN(),
- MasterLoader::DEFAULT);
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_EQ(3, rrsets_.size());
- checkRR("example.org", RRType::SOA(), ". . 0 0 0 0 2147483648", RRTTL(0));
- checkRR("a.example.org", RRType::A(), "192.0.2.1", RRTTL(0));
- checkRR("b.example.org", RRType::A(), "192.0.2.2", RRTTL(0));
- EXPECT_EQ(4, warnings_.size());
- checkCallbackMessage(warnings_.at(1),
- "TTL 2147483648 > MAXTTL, setting to 0 per RFC2181",
- 1);
- checkCallbackMessage(warnings_.at(2),
- "TTL 2147483649 > MAXTTL, setting to 0 per RFC2181",
- 3);
- checkCallbackMessage(warnings_.at(3),
- "TTL 2147483650 > MAXTTL, setting to 0 per RFC2181",
- 6);
- }
- // Test the constructor rejects empty add callback.
- TEST_F(MasterLoaderTest, emptyCallback) {
- EXPECT_THROW(MasterLoader(TEST_DATA_SRCDIR "/example.org",
- Name("example.org"), RRClass::IN(), callbacks_,
- AddRRCallback()), isc::InvalidParameter);
- // And the same with the second constructor
- stringstream ss("");
- EXPECT_THROW(MasterLoader(ss, Name("example.org"), RRClass::IN(),
- callbacks_, AddRRCallback()),
- isc::InvalidParameter);
- }
- // Check it throws when we try to load after loading was complete.
- TEST_F(MasterLoaderTest, loadTwice) {
- setLoader(TEST_DATA_SRCDIR "/example.org", Name("example.org."),
- RRClass::IN(), MasterLoader::MANY_ERRORS);
- loader_->load();
- EXPECT_THROW(loader_->load(), isc::InvalidOperation);
- // Don't check them, they are not interesting, so suppress the error
- // at TearDown
- rrsets_.clear();
- }
- // Load 0 items should be rejected
- TEST_F(MasterLoaderTest, loadZero) {
- setLoader(TEST_DATA_SRCDIR "/example.org", Name("example.org."),
- RRClass::IN(), MasterLoader::MANY_ERRORS);
- EXPECT_THROW(loader_->loadIncremental(0), isc::InvalidParameter);
- }
- // Test there's a warning when the file terminates without end of
- // line.
- TEST_F(MasterLoaderTest, noEOLN) {
- // No \n at the end
- const string input("example.org. 3600 IN SOA ns1.example.org. "
- "admin.example.org. 1234 3600 1800 2419200 7200");
- stringstream ss(input);
- setLoader(ss, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- // There should be one warning about the EOLN
- EXPECT_EQ(1, warnings_.size());
- checkRR("example.org", RRType::SOA(), "ns1.example.org. "
- "admin.example.org. 1234 3600 1800 2419200 7200");
- }
- // Test it rejects when we don't have the previous name to use in place of
- // initial whitespace
- TEST_F(MasterLoaderTest, noPreviousName) {
- const string input(" 1H IN A 192.0.2.1\n");
- stringstream ss(input);
- setLoader(ss, Name("example.org."), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- loader_->load();
- EXPECT_FALSE(loader_->loadedSucessfully());
- EXPECT_EQ(1, errors_.size());
- checkCallbackMessage(errors_.at(0), "No previous name to use in place of "
- "initial whitespace", 1);
- EXPECT_TRUE(warnings_.empty());
- }
- // Check we warn if the first RR in an included file has omitted name
- TEST_F(MasterLoaderTest, previousInInclude) {
- const string input("www 1H IN A 192.0.2.1\n"
- "$INCLUDE " TEST_DATA_SRCDIR "/omitcheck.txt\n");
- stringstream ss(input);
- setLoader(ss, Name("example.org"), RRClass::IN(),
- MasterLoader::MANY_ERRORS);
- loader_->load();
- EXPECT_TRUE(loader_->loadedSucessfully());
- EXPECT_TRUE(errors_.empty());
- // There should be one warning about the EOLN
- EXPECT_EQ(1, warnings_.size());
- checkCallbackMessage(warnings_.at(0), "Owner name omitted around "
- "$INCLUDE, the result might not be as expected", 1);
- checkARR("www.example.org");
- checkARR("www.example.org");
- }
- }
|