masterload_unittest.cc 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404
  1. // Copyright (C) 2010 Internet Systems Consortium, Inc. ("ISC")
  2. //
  3. // Permission to use, copy, modify, and/or distribute this software for any
  4. // purpose with or without fee is hereby granted, provided that the above
  5. // copyright notice and this permission notice appear in all copies.
  6. //
  7. // THE SOFTWARE IS PROVIDED "AS IS" AND ISC DISCLAIMS ALL WARRANTIES WITH
  8. // REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
  9. // AND FITNESS. IN NO EVENT SHALL ISC BE LIABLE FOR ANY SPECIAL, DIRECT,
  10. // INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
  11. // LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE
  12. // OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
  13. // PERFORMANCE OF THIS SOFTWARE.
  14. #include <functional>
  15. #include <ios>
  16. #include <fstream>
  17. #include <sstream>
  18. #include <string>
  19. #include <vector>
  20. #include <boost/bind.hpp>
  21. #include <gtest/gtest.h>
  22. #include <dns/masterload.h>
  23. #include <dns/name.h>
  24. #include <dns/rdata.h>
  25. #include <dns/rrclass.h>
  26. #include <dns/rrset.h>
  27. using namespace std;
  28. using namespace isc::dns;
  29. namespace {
  30. // A callback functor for masterLoad() commonly used for the following tests.
  31. class TestCallback : public unary_function<ConstRRsetPtr, void> {
  32. public:
  33. TestCallback(vector<ConstRRsetPtr>& rrsets) : rrsets_(rrsets) {}
  34. void operator()(ConstRRsetPtr rrset) {
  35. rrsets_.push_back(rrset);
  36. }
  37. private:
  38. vector<ConstRRsetPtr>& rrsets_;
  39. };
  40. // A function version of TestCallback.
  41. void
  42. testCallback(ConstRRsetPtr rrset, vector<ConstRRsetPtr>* rrsets) {
  43. rrsets->push_back(rrset);
  44. }
  45. class MasterLoadTest : public ::testing::Test {
  46. protected:
  47. MasterLoadTest() : origin("example.com"), zclass(RRClass::IN()),
  48. callback(results) {}
  49. public:
  50. void rrsetCallback(ConstRRsetPtr rrset) {
  51. results.push_back(rrset);
  52. }
  53. protected:
  54. Name origin;
  55. RRClass zclass;
  56. stringstream rr_stream;
  57. vector<ConstRRsetPtr> results;
  58. TestCallback callback;
  59. };
  60. // Commonly used test RRs
  61. const char* const txt_rr = "example.com. 3600 IN TXT \"test data\"\n";
  62. const char* const a_rr1 = "www.example.com. 60 IN A 192.0.2.1\n";
  63. const char* const a_rr2 = "www.example.com. 60 IN A 192.0.2.2\n";
  64. const char* const a_rr3 = "ftp.example.com. 60 IN A 192.0.2.3\n";
  65. // multi-field RR case
  66. const char* const soa_rr = "example.com. 7200 IN SOA . . 0 0 0 0 0\n";
  67. // A couple of RRSIGs, different type covered
  68. const char* const rrsig_rr1 =
  69. "www.example.com. 60 IN RRSIG A 5 3 3600 20000101000000 20000201000000 "
  70. "12345 example.com. FAKEFAKEFAKE\n";
  71. const char* const rrsig_rr2 =
  72. "www.example.com. 60 IN RRSIG AAAA 5 3 3600 20000101000000 20000201000000 "
  73. "12345 example.com. FAKEFAKEFAKE\n";
  74. // Commonly used for some tests to check the constructed RR content.
  75. const char* const dnskey_rdata =
  76. "256 3 7 AwEAAaetidLzsKWUt4swWR8yu0wPHPiUi8LUsAD0QPWU+wzt89epO6tH "
  77. "zkMBVDkC7qphQO2hTY4hHn9npWFRw5BYubE=\n";
  78. TEST_F(MasterLoadTest, loadRRs) {
  79. // a simple case: loading 3 RRs, each consists of a single RRset.
  80. rr_stream << txt_rr << a_rr1 << soa_rr;
  81. masterLoad(rr_stream, origin, zclass, callback);
  82. ASSERT_EQ(3, results.size());
  83. EXPECT_EQ(txt_rr, results[0]->toText());
  84. EXPECT_EQ(a_rr1, results[1]->toText());
  85. EXPECT_EQ(soa_rr, results[2]->toText());
  86. }
  87. TEST_F(MasterLoadTest, loadWithFunctionCallback) {
  88. // The same test as loadRRs but using a normal function (not a functor
  89. // object)
  90. rr_stream << txt_rr << a_rr1 << soa_rr;
  91. masterLoad(rr_stream, origin, zclass,
  92. bind2nd(ptr_fun(testCallback), &results));
  93. ASSERT_EQ(3, results.size());
  94. EXPECT_EQ(txt_rr, results[0]->toText());
  95. EXPECT_EQ(a_rr1, results[1]->toText());
  96. EXPECT_EQ(soa_rr, results[2]->toText());
  97. }
  98. TEST_F(MasterLoadTest, loadWithMemFunctionCallback) {
  99. // The same test as loadRRs but using a class member function (with a
  100. // help of Boost.bind)
  101. rr_stream << txt_rr << a_rr1 << soa_rr;
  102. masterLoad(rr_stream, origin, zclass,
  103. boost::bind(&MasterLoadTest::rrsetCallback, this, _1));
  104. ASSERT_EQ(3, results.size());
  105. EXPECT_EQ(txt_rr, results[0]->toText());
  106. EXPECT_EQ(a_rr1, results[1]->toText());
  107. EXPECT_EQ(soa_rr, results[2]->toText());
  108. }
  109. TEST_F(MasterLoadTest, loadComments) {
  110. rr_stream << ";; comment line, should be skipped\n"
  111. << "\n" // blank line (should be skipped)
  112. << txt_rr;
  113. masterLoad(rr_stream, origin, zclass, callback);
  114. ASSERT_EQ(1, results.size());
  115. EXPECT_EQ(txt_rr, results[0]->toText());
  116. }
  117. TEST_F(MasterLoadTest, loadRRset) {
  118. // load an RRset containing two RRs
  119. rr_stream << a_rr1 << a_rr2;
  120. masterLoad(rr_stream, origin, zclass, callback);
  121. ASSERT_EQ(1, results.size());
  122. EXPECT_EQ(string(a_rr1) + string(a_rr2), results[0]->toText());
  123. }
  124. TEST_F(MasterLoadTest, loadRRsetsOfSameType) {
  125. // load two RRsets with the same RR type and different owner names.
  126. // the loader must distinguish them as separate RRsets.
  127. rr_stream << a_rr1 << a_rr3;
  128. masterLoad(rr_stream, origin, zclass, callback);
  129. ASSERT_EQ(2, results.size());
  130. EXPECT_EQ(a_rr1, results[0]->toText());
  131. EXPECT_EQ(a_rr3, results[1]->toText());
  132. }
  133. TEST_F(MasterLoadTest, loadRRsetsInterleaved) {
  134. // two RRs that belongs to the same RRset (rr1 and rr2) are interleaved
  135. // by another. This is an unexpected case for this loader, but it's
  136. // not considered an error. The loader will simply treat them separate
  137. // RRsets.
  138. rr_stream << a_rr1 << a_rr3 << a_rr2;
  139. masterLoad(rr_stream, origin, zclass, callback);
  140. ASSERT_EQ(3, results.size());
  141. EXPECT_EQ(a_rr1, results[0]->toText());
  142. EXPECT_EQ(a_rr3, results[1]->toText());
  143. EXPECT_EQ(a_rr2, results[2]->toText());
  144. }
  145. TEST_F(MasterLoadTest, loadRRsigs) {
  146. // RRSIGs of different types covered should be separated
  147. rr_stream << rrsig_rr1 << rrsig_rr2;
  148. masterLoad(rr_stream, origin, zclass, callback);
  149. EXPECT_EQ(2, results.size());
  150. }
  151. // This test was disabled by #2387, because the test data has trailing
  152. // comments and it (eventually) uses the string RDATA constructor which
  153. // doesn't support them. This test should be fixed and re-enabled by
  154. // #2381, or deleted.
  155. TEST_F(MasterLoadTest, DISABLED_loadRRWithComment) {
  156. // Comment at the end of line should be ignored and the RR should be
  157. // accepted.
  158. rr_stream << "example.com. 3600 IN DNSKEY 256 3 7 "
  159. "AwEAAaetidLzsKWUt4swWR8yu0wPHPiUi8LUsAD0QPWU+wzt89epO6tH "
  160. "zkMBVDkC7qphQO2hTY4hHn9npWFRw5BYubE= ; key id = 40430\n";
  161. masterLoad(rr_stream, origin, zclass, callback);
  162. ASSERT_EQ(1, results.size());
  163. EXPECT_EQ(0, results[0]->getRdataIterator()->getCurrent().compare(
  164. *rdata::createRdata(RRType::DNSKEY(), zclass,
  165. dnskey_rdata)));
  166. }
  167. // This test was disabled by #2387, because the test data has trailing
  168. // comments and it (eventually) uses the string RDATA constructor which
  169. // doesn't support them. This test should be fixed and re-enabled by
  170. // #2381, or deleted.
  171. TEST_F(MasterLoadTest, DISABLED_loadRRWithCommentNoSpace) {
  172. // Similar to the previous one, but there's no space before comments.
  173. // It should still work.
  174. rr_stream << "example.com. 3600 IN DNSKEY 256 3 7 "
  175. "AwEAAaetidLzsKWUt4swWR8yu0wPHPiUi8LUsAD0QPWU+wzt89epO6tH "
  176. "zkMBVDkC7qphQO2hTY4hHn9npWFRw5BYubE=; key id = 40430\n";
  177. masterLoad(rr_stream, origin, zclass, callback);
  178. ASSERT_EQ(1, results.size());
  179. EXPECT_EQ(0, results[0]->getRdataIterator()->getCurrent().compare(
  180. *rdata::createRdata(RRType::DNSKEY(), zclass,
  181. dnskey_rdata)));
  182. }
  183. // This test was disabled by #2387, because the test data has trailing
  184. // comments and it (eventually) uses the string RDATA constructor which
  185. // doesn't support them. This test should be fixed and re-enabled by
  186. // #2381, or deleted.
  187. TEST_F(MasterLoadTest, DISABLED_loadRRWithCommentEmptyComment) {
  188. // Similar to the previous one, but there's no data after the ;
  189. // It should still work.
  190. rr_stream << "example.com. 3600 IN DNSKEY 256 3 7 "
  191. "AwEAAaetidLzsKWUt4swWR8yu0wPHPiUi8LUsAD0QPWU+wzt89epO6tH "
  192. "zkMBVDkC7qphQO2hTY4hHn9npWFRw5BYubE= ;\n";
  193. masterLoad(rr_stream, origin, zclass, callback);
  194. ASSERT_EQ(1, results.size());
  195. EXPECT_EQ(0, results[0]->getRdataIterator()->getCurrent().compare(
  196. *rdata::createRdata(RRType::DNSKEY(), zclass,
  197. dnskey_rdata)));
  198. }
  199. // This test was disabled by #2387, because the test data has trailing
  200. // comments and it (eventually) uses the string RDATA constructor which
  201. // doesn't support them. This test should be fixed and re-enabled by
  202. // #2381, or deleted.
  203. TEST_F(MasterLoadTest, DISABLED_loadRRWithCommentEmptyCommentNoSpace) {
  204. // Similar to the previous one, but there's no space before or after ;
  205. // It should still work.
  206. rr_stream << "example.com. 3600 IN DNSKEY 256 3 7 "
  207. "AwEAAaetidLzsKWUt4swWR8yu0wPHPiUi8LUsAD0QPWU+wzt89epO6tH "
  208. "zkMBVDkC7qphQO2hTY4hHn9npWFRw5BYubE=;\n";
  209. masterLoad(rr_stream, origin, zclass, callback);
  210. ASSERT_EQ(1, results.size());
  211. EXPECT_EQ(0, results[0]->getRdataIterator()->getCurrent().compare(
  212. *rdata::createRdata(RRType::DNSKEY(), zclass,
  213. dnskey_rdata)));
  214. }
  215. TEST_F(MasterLoadTest, loadRRWithEOLWhitespace) {
  216. // Test with whitespace after rdata
  217. // It should still work.
  218. rr_stream << "example.com. 3600 IN NSEC3PARAM 1 0 1 beef \n";
  219. masterLoad(rr_stream, origin, zclass, callback);
  220. ASSERT_EQ(1, results.size());
  221. EXPECT_EQ(0, results[0]->getRdataIterator()->getCurrent().compare(
  222. *rdata::createRdata(RRType::NSEC3PARAM(), zclass,
  223. "1 0 1 beef")));
  224. }
  225. TEST_F(MasterLoadTest, loadRRWithEOLWhitespaceTab) {
  226. // Similar to the previous one, tab instead of space.
  227. // It should still work.
  228. rr_stream << "example.com. 3600 IN NSEC3PARAM 1 0 1 beef\t\n";
  229. masterLoad(rr_stream, origin, zclass, callback);
  230. ASSERT_EQ(1, results.size());
  231. EXPECT_EQ(0, results[0]->getRdataIterator()->getCurrent().compare(
  232. *rdata::createRdata(RRType::NSEC3PARAM(), zclass,
  233. "1 0 1 beef")));
  234. }
  235. TEST_F(MasterLoadTest, loadRRNoComment) {
  236. // A semicolon in a character-string shouldn't confuse the parser.
  237. rr_stream << "example.com. 3600 IN TXT \"aaa;bbb\"\n";
  238. masterLoad(rr_stream, origin, zclass, callback);
  239. EXPECT_EQ(1, results.size());
  240. EXPECT_EQ(0, results[0]->getRdataIterator()->getCurrent().compare(
  241. *rdata::createRdata(RRType::TXT(), zclass,
  242. "\"aaa;bbb\"")));
  243. }
  244. TEST_F(MasterLoadTest, nonAbsoluteOwner) {
  245. // If the owner name is not absolute, the zone origin is assumed to be
  246. // its origin.
  247. rr_stream << "example.com 3600 IN A 192.0.2.1";
  248. masterLoad(rr_stream, origin, zclass, callback);
  249. EXPECT_EQ(1, results.size());
  250. EXPECT_EQ(results[0]->getName(), Name("example.com.example.com"));
  251. }
  252. TEST_F(MasterLoadTest, loadRREmptyAndComment) {
  253. // There's no RDATA (invalid in this case) but a comment. This position
  254. // shouldn't cause any disruption and should be treated as a normal error.
  255. rr_stream << "example.com. 3600 IN A ;\n";
  256. EXPECT_THROW(masterLoad(rr_stream, origin, zclass, callback),
  257. MasterLoadError);
  258. }
  259. TEST_F(MasterLoadTest, loadWithNoEOF) {
  260. // the input stream doesn't end with a new line (and the following blank
  261. // line). It should be accepted.
  262. string rr_string(a_rr1);
  263. rr_string.erase(rr_string.end() - 1);
  264. rr_stream << rr_string;
  265. masterLoad(rr_stream, origin, zclass, callback);
  266. ASSERT_EQ(1, results.size());
  267. EXPECT_EQ(a_rr1, results[0]->toText());
  268. }
  269. TEST_F(MasterLoadTest, loadEmpty) {
  270. // an unusual case: empty input. load must succeed with an empty result.
  271. masterLoad(rr_stream, origin, zclass, callback);
  272. EXPECT_EQ(0, results.size());
  273. }
  274. TEST_F(MasterLoadTest, loadWithBeginningSpace) {
  275. rr_stream << " " << a_rr1;
  276. EXPECT_THROW(masterLoad(rr_stream, origin, zclass, callback),
  277. MasterLoadError);
  278. }
  279. TEST_F(MasterLoadTest, loadWithBeginningTab) {
  280. rr_stream << "\t" << a_rr1;
  281. EXPECT_THROW(masterLoad(rr_stream, origin, zclass, callback),
  282. MasterLoadError);
  283. }
  284. TEST_F(MasterLoadTest, loadInvalidRRClass) {
  285. rr_stream << "example.com. 3600 CH TXT \"test text\"";
  286. EXPECT_THROW(masterLoad(rr_stream, origin, zclass, callback),
  287. MasterLoadError);
  288. }
  289. TEST_F(MasterLoadTest, loadOutOfZoneData) {
  290. rr_stream << "example.org. 3600 IN A 192.0.2.255";
  291. EXPECT_THROW(masterLoad(rr_stream, origin, zclass, callback),
  292. MasterLoadError);
  293. }
  294. TEST_F(MasterLoadTest, loadNonAtopSOA) {
  295. // SOA's owner name must be zone's origin.
  296. rr_stream << "soa.example.com. 3600 IN SOA . . 0 0 0 0 0";
  297. EXPECT_THROW(masterLoad(rr_stream, origin, zclass, callback),
  298. MasterLoadError);
  299. }
  300. // Load TTL with units
  301. TEST_F(MasterLoadTest, loadUnitTTL) {
  302. stringstream rr_stream2("example.com. 1D IN A 192.0.2.1");
  303. masterLoad(rr_stream2, origin, zclass, callback);
  304. EXPECT_EQ(1, results.size());
  305. EXPECT_EQ(0, results[0]->getRdataIterator()->getCurrent().compare(
  306. *rdata::createRdata(RRType::A(), zclass, "192.0.2.1")));
  307. }
  308. TEST_F(MasterLoadTest, loadBadRRText) {
  309. rr_stream << "example..com. 3600 IN A 192.0.2.1"; // bad owner name
  310. EXPECT_THROW(masterLoad(rr_stream, origin, zclass, callback),
  311. MasterLoadError);
  312. // bad RR class text
  313. stringstream rr_stream3("example.com. 3600 BAD A 192.0.2.1");
  314. EXPECT_THROW(masterLoad(rr_stream3, origin, zclass, callback),
  315. MasterLoadError);
  316. // bad RR type text
  317. stringstream rr_stream4("example.com. 3600 IN BAD 192.0.2.1");
  318. EXPECT_THROW(masterLoad(rr_stream4, origin, zclass, callback),
  319. MasterLoadError);
  320. // bad RDATA text
  321. stringstream rr_stream5("example.com. 3600 IN A 2001:db8::1");
  322. EXPECT_THROW(masterLoad(rr_stream5, origin, zclass, callback),
  323. MasterLoadError);
  324. // incomplete RR text
  325. stringstream rr_stream6("example.com. 3600 IN A");
  326. EXPECT_THROW(masterLoad(rr_stream6, origin, zclass, callback),
  327. MasterLoadError);
  328. }
  329. // This is a helper callback to test the case the input stream becomes bad
  330. // in the middle of processing.
  331. class StreamInvalidator : public unary_function<ConstRRsetPtr, void> {
  332. public:
  333. StreamInvalidator(stringstream& ss) : ss_(ss) {}
  334. void operator()(ConstRRsetPtr) {
  335. ss_.setstate(ios::badbit);
  336. }
  337. private:
  338. stringstream& ss_;
  339. };
  340. TEST_F(MasterLoadTest, loadBadStream) {
  341. rr_stream << txt_rr << a_rr1;
  342. StreamInvalidator invalidator(rr_stream);
  343. EXPECT_THROW(masterLoad(rr_stream, origin, zclass, invalidator),
  344. MasterLoadError);
  345. }
  346. TEST_F(MasterLoadTest, loadFromFile) {
  347. // The main parser is shared with the stream version, so we simply test
  348. // file I/O specific parts.
  349. masterLoad(TEST_DATA_SRCDIR "/masterload.txt", origin, zclass, callback);
  350. ASSERT_EQ(2, results.size());
  351. EXPECT_EQ(txt_rr, results[0]->toText());
  352. EXPECT_EQ(string(a_rr1) + string(a_rr2), results[1]->toText());
  353. // NULL file name. Should result in exception.
  354. EXPECT_THROW(masterLoad(NULL, origin, zclass, callback), MasterLoadError);
  355. // Non existent file name. Ditto.
  356. EXPECT_THROW(masterLoad(TEST_DATA_BUILDDIR "/notexistent.txt", origin,
  357. zclass, callback), MasterLoadError);
  358. }
  359. } // end namespace