Parcourir la source

Closes #630: Added a custom 404 page

Jeremy Stretch il y a 8 ans
Parent
commit
f44a322df5
3 fichiers modifiés avec 31 ajouts et 10 suppressions
  1. 1 3
      netbox/netbox/urls.py
  2. 11 7
      netbox/netbox/views.py
  3. 19 0
      netbox/templates/404.html

+ 1 - 3
netbox/netbox/urls.py

@@ -1,9 +1,8 @@
 from django.conf import settings
 from django.conf import settings
 from django.conf.urls import include, url
 from django.conf.urls import include, url
 from django.contrib import admin
 from django.contrib import admin
-from django.views.defaults import page_not_found
 
 
-from views import home, trigger_500, handle_500
+from views import home, handle_500, trigger_500
 from users.views import login, logout
 from users.views import login, logout
 
 
 
 
@@ -36,7 +35,6 @@ _patterns = [
     url(r'^api-auth/', include('rest_framework.urls', namespace='rest_framework')),
     url(r'^api-auth/', include('rest_framework.urls', namespace='rest_framework')),
 
 
     # Error testing
     # Error testing
-    url(r'^404/$', page_not_found),
     url(r'^500/$', trigger_500),
     url(r'^500/$', trigger_500),
 
 
     # Admin
     # Admin

+ 11 - 7
netbox/netbox/views.py

@@ -47,16 +47,20 @@ def home(request):
     })
     })
 
 
 
 
-def trigger_500(request):
-    """Hot-wired method of triggering a server error to test reporting."""
-    raise Exception("Congratulations, you've triggered an exception! Go tell all your friends what an exceptional "
-                    "person you are.")
-
-
 def handle_500(request):
 def handle_500(request):
-    """Custom server error handler"""
+    """
+    Custom server error handler
+    """
     type_, error, traceback = sys.exc_info()
     type_, error, traceback = sys.exc_info()
     return render(request, '500.html', {
     return render(request, '500.html', {
         'exception': str(type_),
         'exception': str(type_),
         'error': error,
         'error': error,
     }, status=500)
     }, status=500)
+
+
+def trigger_500(request):
+    """
+    Hot-wired method of triggering a server error to test reporting
+    """
+    raise Exception("Congratulations, you've triggered an exception! Go tell all your friends what an exceptional "
+                    "person you are.")

+ 19 - 0
netbox/templates/404.html

@@ -0,0 +1,19 @@
+{% extends '_base.html' %}
+
+{% block content %}
+<div class="row" style="margin-top: 150px;">
+    <div class="col-sm-4 col-sm-offset-4">
+        <div class="panel panel-default">
+            <div class="panel-heading">
+                <strong><i class="glyphicon glyphicon-warning-sign"></i> Page Not Found</strong>
+            </div>
+            <div class="panel-body">
+                The requested page does not exist.
+            </div>
+            <div class="panel-footer text-right">
+                <a href="{% url 'home' %}" class="btn btn-xs btn-primary">Home Page</a>
+            </div>
+        </div>
+    </div>
+</div>
+{% endblock %}