#18 "Cone of vision" broken on some panorama with firefox

Closed
opened 8 years ago by zorun · 3 comments
zorun commented 8 years ago

With firefox, the cone of vision is not displayed for some panoramas. For instance, in Rézine's instance, Rabot and Gambetta are broken. The console says this:

jQuery.Deferred exception: canvas is undefined getCapMinMaxVisible@https://pano.rezine.org/static/panorama/js/pano.js:1192:9
update_map@https://pano.rezine.org/static/panorama/js/pano.js:1288:15
load_map@https://pano.rezine.org/static/panorama/js/pano.js:1273:5
g/</j@https://pano.rezine.org/static/panorama/js/jquery-3.0.0.min.js:2:29586
g/</k<@https://pano.rezine.org/static/panorama/js/jquery-3.0.0.min.js:2:29902
 undefined

It works fine with chromium

With firefox, the cone of vision is not displayed for some panoramas. For instance, in Rézine's instance, Rabot and Gambetta are broken. The console says this: ``` jQuery.Deferred exception: canvas is undefined getCapMinMaxVisible@https://pano.rezine.org/static/panorama/js/pano.js:1192:9 update_map@https://pano.rezine.org/static/panorama/js/pano.js:1288:15 load_map@https://pano.rezine.org/static/panorama/js/pano.js:1273:5 g/</j@https://pano.rezine.org/static/panorama/js/jquery-3.0.0.min.js:2:29586 g/</k<@https://pano.rezine.org/static/panorama/js/jquery-3.0.0.min.js:2:29902 undefined ``` It works fine with chromium
Samuel commented 8 years ago
Collaborator

I can't reproduce it. I have Firefox 49. Btw it's weird: "canvas is undefined", but "canvas" is set with the

<script>window.onload = load_pano</script>

, line 39 in view.html and the minimap is only draw after:

  $( document ).ready(load_map);

, line 105 in view.html.

Maybe is a question of speed... The function load_pano is not finish before load_map is run.

We may stop all scripts before the end of 'load_pano'. How to do it?

EDIT: Ok. I can reproduce it. It's random with "ctrl+F5". So I would say it's a matter of speed between the 2 functions.

I can't reproduce it. I have Firefox 49. Btw it's weird: "canvas is undefined", but "canvas" is set with the <script>window.onload = load_pano</script> , line 39 in view.html and the minimap is only draw after: $( document ).ready(load_map); , line 105 in view.html. Maybe is a question of speed... The function load_pano is not finish before load_map is run. We may stop all scripts before the end of 'load_pano'. How to do it? EDIT: Ok. I can reproduce it. It's random with "ctrl+F5". So I would say it's a matter of speed between the 2 functions.
Samuel commented 8 years ago
Collaborator

Should be fix. Need more test, but theoritically fix.

Should be fix. Need more test, but *theoritically* fix.
zorun commented 8 years ago
Owner

Indeed, it now works better, thanks!

Indeed, it now works better, thanks!
Sign in to join this conversation.
No Label
bug
ui
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.