#39 Add lib django-phonenumber-field for valide and normalize the phone number

Closed
neodarz wants to merge 2 commits from neodarz/phone_number_validation into FFDN/master
neodarz commented 7 years ago

This fix issue #38.

This fix issue #38.
jocelyn commented 7 years ago
Owner

Thanks a lot :-).

Not yet tested, but already have a few remarks :

  • please specify a version for the dependency (Hint: pip freeze will tell you which version is installed.)
  • I think there should be a migration associated to this change.
Thanks a lot :-). Not yet tested, but already have a few remarks : - please specify a version for the dependency (Hint: `pip freeze` will tell you which version is installed.) - I think there should be a [migration](https://docs.djangoproject.com/en/1.8/topics/migrations/) associated to this change.
neodarz commented 7 years ago
Poster

Yes there is a migration associated with this change, this will be problematic ?

And there is the output of pip freeze :

Babel==2.4.0
Django==1.9.13
django-debug-toolbar==1.8
django-phonenumber-field==1.3.0
phonenumberslite==8.7.1
pytz==2017.2
PyYAML==3.12
sqlparse==0.2.3
Yes there is a migration associated with this change, this will be problematic ? And there is the output of ``pip freeze`` : ``` Babel==2.4.0 Django==1.9.13 django-debug-toolbar==1.8 django-phonenumber-field==1.3.0 phonenumberslite==8.7.1 pytz==2017.2 PyYAML==3.12 sqlparse==0.2.3 ```
jocelyn commented 7 years ago
Owner

Here I am, sorry for huuuuge delay...

Yes there is a migration associated with this change, this will be problematic ?

No, but you forgot to include the migration file to your commit (git add...)

And there is the output of pip freeze : [...]

thus you should reflect it in requirements.txt, something like

django-phonenumber-field==1.3.0

instead of just

django-phonenumber-field

Or better, you can add bounds, so that it auto-upgrades on patch realeases, like:

django-phonenumber-field==1.3.0,<1.4.0
Here I am, sorry for huuuuge delay... > Yes there is a migration associated with this change, this will be problematic ? No, but you forgot to include the migration file to your commit (`git add`...) > And there is the output of pip freeze : [...] thus you should reflect it in requirements.txt, something like django-phonenumber-field==1.3.0 instead of just django-phonenumber-field Or better, you can add bounds, so that it auto-upgrades on patch realeases, like: django-phonenumber-field==1.3.0,<1.4.0
jocelyn commented 6 years ago
Owner

Cleaning up, closing. feel free to re-open if you have to :)

Cleaning up, closing. feel free to re-open if you have to :)
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.